Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/common/bluetooth/bluetooth_messages.h

Issue 1156573005: bluetooth: Browser-side implementation of getCharacteristic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-get-primary-service-initial
Patch Set: Small fixes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/child/bluetooth/bluetooth_dispatcher.cc ('K') | « content/child/bluetooth/web_bluetooth_impl.cc ('k') | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h » ('j') | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/bluetooth/bluetooth_messages.h
diff --git a/content/common/bluetooth/bluetooth_messages.h b/content/common/bluetooth/bluetooth_messages.h
index 1c9f1d8ec89602b5e7d733c9aa5746780830efc4..c4c31d6d3c32df9d32e7dd3376d3a26a4a357fbd 100644
--- a/content/common/bluetooth/bluetooth_messages.h
+++ b/content/common/bluetooth/bluetooth_messages.h
@@ -135,12 +135,24 @@ IPC_MESSAGE_CONTROL3(BluetoothMsg_GetPrimaryServiceSuccess,
int /* request_id */,
std::string /* service_instance_id */)
-// Informs the renderer that the primary service request |request_id| failed.
+// Informs the renderer that the primary_service request |request_id| failed.
Jeffrey Yasskin 2015/06/02 22:12:29 Why the extra '_' here?
ortuno 2015/06/03 20:27:23 Done.
IPC_MESSAGE_CONTROL3(BluetoothMsg_GetPrimaryServiceError,
int /* thread_id */,
int /* request_id */,
content::BluetoothError /* result */)
+// Informs the renderer that characteristic request |request_id| succeeded.
+IPC_MESSAGE_CONTROL3(BluetoothMsg_GetCharacteristicSuccess,
+ int /* thread_id */,
+ int /* request_id */,
+ std::string /* characteristic_instance_id */)
+
+// Informs the renderer that the characteristic request |request_id| failed.
+IPC_MESSAGE_CONTROL3(BluetoothMsg_GetCharacteristicError,
+ int /* thread_id */,
+ int /* request_id */,
+ content::BluetoothError /* result */)
+
// Messages sent from the renderer to the browser.
// Requests a bluetooth device from the browser.
@@ -166,3 +178,10 @@ IPC_MESSAGE_CONTROL4(BluetoothHostMsg_GetPrimaryService,
int /* request_id */,
std::string /* device_instance_id */,
std::string /* service_uuid */)
+
+// Gets a GATT Characteristic from a bluetooth device.
Jeffrey Yasskin 2015/06/02 22:12:29 s/from a bluetooth device/within a GATT Service/?
ortuno 2015/06/03 20:27:23 Done.
+IPC_MESSAGE_CONTROL4(BluetoothHostMsg_GetCharacteristic,
+ int /* thread_id */,
+ int /* request_id */,
+ std::string /* service_instance_id */,
+ std::string /* characteristic_uuid */)
« content/child/bluetooth/bluetooth_dispatcher.cc ('K') | « content/child/bluetooth/web_bluetooth_impl.cc ('k') | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h » ('j') | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698