device/bluetooth/test/mock_bluetooth_adapter.h - Issue 1156573005: bluetooth: Browser-side implementation of getCharacteristic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/test/mock_bluetooth_adapter.h

Issue 1156573005: bluetooth: Browser-side implementation of getCharacteristic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-get-primary-service-initial

Patch Set: Address scheib's and nick's comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc ('k') | device/bluetooth/test/mock_bluetooth_device.h » ('j') | device/bluetooth/test/mock_bluetooth_device.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/test/mock_bluetooth_adapter.h

diff --git a/device/bluetooth/test/mock_bluetooth_adapter.h b/device/bluetooth/test/mock_bluetooth_adapter.h

index cd8b8a1bb87fa5ad34f1d120f55cc2af6a4d4804..f8c0baecdc931cf87825669f4d86f1efe6cce405 100644

--- a/device/bluetooth/test/mock_bluetooth_adapter.h

+++ b/device/bluetooth/test/mock_bluetooth_adapter.h

@@ -102,7 +102,7 @@ class MockBluetoothAdapter : public BluetoothAdapter {

const ErrorCallback& error_callback);

// BluetoothAdapter is supposed to manage the lifetime of BluetoothDevices.

- // This methods takes ownership of the BluetoothDevices. This is only for

+ // This methods takes ownership of the MockBluetoothDevice. This is only for

armansito 2015/06/09 19:23:48 nit: s/This methods/This method/

ortuno 2015/06/09 20:46:42 Done.

// convenience as far testing is concerned and it's possible to write test

// cases without using these functions.

void AddMockDevice(scoped_ptr<MockBluetoothDevice> mock_device);