Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: src/elements.cc

Issue 1156573002: [strong] Implement per-object restrictions behaviour of delete operator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/messages.h » ('j') | test/mjsunit/strong/object-delete.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index 0237a97f4bc73311a1747b5a763d374b8a192912..2e9f36863f847d75a9460a6f96030b2c4fc3cc47 100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -1401,8 +1401,8 @@ class DictionaryElementsAccessor
Handle<SeededNumberDictionary>::cast(backing_store);
int entry = dictionary->FindEntry(key);
if (entry != SeededNumberDictionary::kNotFound) {
- Handle<Object> result =
- SeededNumberDictionary::DeleteProperty(dictionary, entry);
+ Handle<Object> result = SeededNumberDictionary::DeleteProperty(
+ dictionary, entry, obj->map()->is_strong());
rossberg 2015/05/22 14:01:26 Do we have to pass down the flag here? It seems th
conradw 2015/05/27 18:09:32 Yes, missed this.
if (*result == *isolate->factory()->false_value()) {
if (is_strict(language_mode)) {
// Deleting a non-configurable property in strict mode.
« no previous file with comments | « no previous file | src/messages.h » ('j') | test/mjsunit/strong/object-delete.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698