[strong] Implement per-object restrictions behaviour of delete operator

src/objects.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <iomanip>
 #include <sstream>
 
 #include "src/v8.h"
 
 #include "src/accessors.h"
@@ skipping 5495 matching lines @@
     }
   }
 
   return it.isolate()->factory()->true_value();
 }
 
 
 MaybeHandle<Object> JSReceiver::DeleteElement(Handle<JSReceiver> object,
                                               uint32_t index,
                                               LanguageMode language_mode) {
+  if (object->map()->is_strong()) {
+    Isolate* isolate = object->GetIsolate();
+    if (is_strict(language_mode)) {
+      THROW_NEW_ERROR(

[rossberg, 2015/05/22 11:34:50]

Why do we need to throw here? Returning false should already cause an exception
if invoked in strict mode.

[conradw, 2015/05/22 13:37:56]

Discussed offline, throw is needed but is in wrong place.

+          isolate,
+          NewTypeError(MessageTemplate::kStrongDeleteProperty,
+                       isolate->factory()->NewNumberFromUint(index), object),
+          Object);
+    }
+    return isolate->factory()->false_value();
+  }
   if (object->IsJSProxy()) {
     return JSProxy::DeleteElementWithHandler(Handle<JSProxy>::cast(object),
                                              index, language_mode);
   }
   return JSObject::DeleteElement(Handle<JSObject>::cast(object), index,
                                  language_mode);
 }
 
 
 MaybeHandle<Object> JSReceiver::DeleteProperty(Handle<JSReceiver> object,
                                                Handle<Name> name,
                                                LanguageMode language_mode) {
+  if (object->map()->is_strong()) {
+    Isolate* isolate = object->GetIsolate();
+    if (is_strict(language_mode)) {
+      THROW_NEW_ERROR(

[rossberg, 2015/05/22 11:34:50]

Same here.

[conradw, 2015/05/22 13:37:56]

See above.

+          isolate,
+          NewTypeError(MessageTemplate::kStrongDeleteProperty, name, object),
+          Object);
+    }
+    return isolate->factory()->false_value();
+  }
   if (object->IsJSProxy()) {
     return JSProxy::DeletePropertyWithHandler(Handle<JSProxy>::cast(object),
                                               name, language_mode);
   }
   return JSObject::DeleteProperty(Handle<JSObject>::cast(object), name,
                                   language_mode);
 }
 
 
 bool JSObject::ReferencesObjectFromElements(FixedArray* elements,
@@ skipping 11715 matching lines @@
 void PropertyCell::SetValueWithInvalidation(Handle<PropertyCell> cell,
                                             Handle<Object> new_value) {
   if (cell->value() != *new_value) {
     cell->set_value(*new_value);
     Isolate* isolate = cell->GetIsolate();
     cell->dependent_code()->DeoptimizeDependentCodeGroup(
         isolate, DependentCode::kPropertyCellChangedGroup);
   }
 }
 } }  // namespace v8::internal