net/http/http_server_properties.h - Issue 1156563004: Convert bare pointer to scoped_ptr in net/http

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_server_properties.h

Issue 1156563004: Convert bare pointer to scoped_ptr in net/http (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated Review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_server_properties.h

diff --git a/net/http/http_server_properties.h b/net/http/http_server_properties.h

index c9a18f245ccb334161e5cbf8e35e07b04effbe59..5d38672be69ef8589ee216340e4f8f53365a8985 100644

--- a/net/http/http_server_properties.h

+++ b/net/http/http_server_properties.h

@@ -271,7 +271,7 @@ class NET_EXPORT HttpServerProperties {

virtual const AlternativeServiceMap& alternative_service_map() const = 0;

// Returns all alternative service mappings as human readable strings.

- virtual base::Value* GetAlternativeServiceInfoAsValue() const = 0;

+ virtual scoped_ptr<base::Value> GetAlternativeServiceInfoAsValue() const = 0;

// Sets the threshold to be used when evaluating alternative service

// advertisments. Only advertisements with a probability greater than or equal