Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1156543004: [Effen] Fork stocks and fn.dart so we have something to work on during the porting process (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Fork stocks and fn.dart so we have something to work on during the porting process R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e8f018a12be7e84667bbc05795cd658faaab221c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, --33 lines) Patch
A sky/examples/stocks2/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_0.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_1.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_10.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_11.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_12.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_13.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_14.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_15.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_16.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_17.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_18.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_19.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_2.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_20.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_21.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_22.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_23.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_24.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_25.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_26.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_27.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_28.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_29.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_3.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_4.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_5.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_6.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_7.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_8.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/data/stock_data_9.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/examples/stocks2/lib/stock_app.dart View 1 chunk +227 lines, -0 lines 0 comments Download
A + sky/examples/stocks2/lib/stock_arrow.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/lib/stock_data.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/lib/stock_list.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/lib/stock_menu.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/lib/stock_row.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/stocks2/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/fn2.dart View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
eseidel
lgtm
5 years, 7 months ago (2015-05-26 19:52:26 UTC) #3
Hixie
5 years, 7 months ago (2015-05-26 19:53:12 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e8f018a12be7e84667bbc05795cd658faaab221c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698