Issue 1156513004: HttpServerProperties - Don't persist if ClearAlternativeService is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156513004: HttpServerProperties - Don't persist if ClearAlternativeService is (Closed)

Created:
5 years, 6 months ago by ramant (doing other things)

Modified:
5 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

HttpServerProperties - Don't persist if ClearAlternativeService is called with the same origin (HostPortPair) and nothing was deleted. This change reduces the number of times ClearAlternativeService tries to persist HttpServerProperties to disk (currently ~11% of persist calls are due to ClearAlternativeService). BUG=451256 R=rch@chromium.org Committed: https://crrev.com/cefb99b8043239c486ce4b43ca758dd2d4d0d635 Cr-Commit-Position: refs/heads/master@{#333147}

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	net/http/http_server_properties_manager.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download
	M	net/http/http_server_properties_manager_unittest.cc	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156513004/1

5 years, 6 months ago (2015-06-05 21:49:38 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 21:57:47 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cefb99b8043239c486ce4b43ca758dd2d4d0d635
Cr-Commit-Position: refs/heads/master@{#333147}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages