Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
11565044:
Add win8 aura bot to chromium.win, make tryserver match (Closed)
|
Created:
8 years ago by scottmg Modified:
7 years, 11 months ago CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org Visibility:
Public. |
DescriptionAdd win8 aura bot to chromium.win, make tryserver a closer match
Running only a minimal set of tests currently.
BUG=154081, 168808
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=175844
Patch Set 1 #Patch Set 2 : #
Total comments: 5
Patch Set 3 : #
Total comments: 6
Patch Set 4 : #Patch Set 5 : #
Total comments: 2
Patch Set 6 : #
Total comments: 16
Patch Set 7 : #
Messages
Total messages: 26 (0 generated)
lgtm, would like petermayo to take a look, too Do you mean for the "chromium.win" gatekeeper to watch this build config, too? (It should as it's already configured, just want to confirm.)
On 2012/12/17 02:50:02, cmp wrote: > lgtm, would like petermayo to take a look, too > > Do you mean for the "chromium.win" gatekeeper to watch this build config, too? > (It should as it's already configured, just want to confirm.) Yes, the goal was to have it on chromium.win. The target list is conservative for now so it shouldn't cause too much noise (famous last words). I'm not clear on the other pieces that need to be set up, but I guess there needs to be a CQ bot and a try bot to go with this one then?
I'm not sure why we are calling the windows bots with aura ash bots and the other bots with aura aura bots. As it is, I don't see a difference between the aura and the ash bots other than label. This seems overly confusing and backwards. https://codereview.chromium.org/11565044/diff/4/masters/master.chromium.win/m... File masters/master.chromium.win/master_win_cfg.py (right): https://codereview.chromium.org/11565044/diff/4/masters/master.chromium.win/m... masters/master.chromium.win/master_win_cfg.py:379: aura_gyp_defines = ('use_aura=1 win_debug_disable_iterator_debugging=1') ash_gyp_defines = ... use_ash=1 ...
On 2012/12/17 20:20:22, Peter Mayo wrote: > I'm not sure why we are calling the windows bots with aura ash bots and the > other bots with aura aura bots. > > As it is, I don't see a difference between the aura and the ash bots other than > label. This seems overly confusing and backwards. There's only one build time configuration, but we need to test two different runtime configurations. We've been calling the two configs "aura" and "ash" for concision, but more detailed names would be "Win Aura Desktop" and "Win Aura Ash-in-Metro" if you'd prefer. > > https://codereview.chromium.org/11565044/diff/4/masters/master.chromium.win/m... > File masters/master.chromium.win/master_win_cfg.py (right): > > https://codereview.chromium.org/11565044/diff/4/masters/master.chromium.win/m... > masters/master.chromium.win/master_win_cfg.py:379: aura_gyp_defines = > ('use_aura=1 win_debug_disable_iterator_debugging=1') > ash_gyp_defines = ... use_ash=1 ...
https://codereview.chromium.org/11565044/diff/4/masters/master.chromium.win/m... File masters/master.chromium.win/master_win_cfg.py (right): https://codereview.chromium.org/11565044/diff/4/masters/master.chromium.win/m... masters/master.chromium.win/master_win_cfg.py:379: aura_gyp_defines = ('use_aura=1 win_debug_disable_iterator_debugging=1') On 2012/12/17 20:20:22, Peter Mayo wrote: > ash_gyp_defines = ... use_ash=1 ... Remove this assignment, it is redundant. Given this is building exactly the same content as the win Aura bot, perhaps we can add a trigger and re-use the same build? I'm not sure whether "builder-tester, tester" or "builder,tester,tester" is the best pattern, but I suspect the latter. https://codereview.chromium.org/11565044/diff/4/masters/master.chromium.win/m... masters/master.chromium.win/master_win_cfg.py:396: 'generate_gtest_json': True})) Does this actually become ash by virtue of running on Win8?
https://codereview.chromium.org/11565044/diff/4/masters/master.chromium.win/m... File masters/master.chromium.win/master_win_cfg.py (right): https://codereview.chromium.org/11565044/diff/4/masters/master.chromium.win/m... masters/master.chromium.win/master_win_cfg.py:379: aura_gyp_defines = ('use_aura=1 win_debug_disable_iterator_debugging=1') On 2012/12/17 20:38:17, Peter Mayo wrote: > On 2012/12/17 20:20:22, Peter Mayo wrote: > > ash_gyp_defines = ... use_ash=1 ... > > Remove this assignment, it is redundant. Done. > > Given this is building exactly the same content as the win Aura bot, perhaps we > can add a trigger and re-use the same build? I'm not sure whether > "builder-tester, tester" or "builder,tester,tester" is the best pattern, but I > suspect the latter. Done, I think. I have precious little idea what I'm doing in here, so extra careful scrutiny appreciated. https://codereview.chromium.org/11565044/diff/4/masters/master.chromium.win/m... masters/master.chromium.win/master_win_cfg.py:396: 'generate_gtest_json': True})) On 2012/12/17 20:38:17, Peter Mayo wrote: > Does this actually become ash by virtue of running on Win8? Yes. (Sort of. Or at least, as close as we can get right now in an automated fashion.)
https://codereview.chromium.org/11565044/diff/11001/masters/master.chromium.w... File masters/master.chromium.win/master_win_cfg.py (right): https://codereview.chromium.org/11565044/diff/11001/masters/master.chromium.w... masters/master.chromium.win/master_win_cfg.py:356: B('Win Aura', 'dbg_aura', 'compile|windows', 'win_dbg', Win Aura Builder? Arg 1 needs to be distinct. https://codereview.chromium.org/11565044/diff/11001/masters/master.chromium.w... File masters/master.chromium.win/slaves.cfg (right): https://codereview.chromium.org/11565044/diff/11001/masters/master.chromium.w... masters/master.chromium.win/slaves.cfg:313: 'builder': 'Win Aura', 'builder': ['Win Aura Builder', 'Win Aura',], or allocate another slave https://codereview.chromium.org/11565044/diff/11001/masters/master.tryserver.... File masters/master.tryserver.chromium/master.cfg (right): https://codereview.chromium.org/11565044/diff/11001/masters/master.tryserver.... masters/master.tryserver.chromium/master.cfg:1319: b_win_ash = CreateBuilder( Should we move this to win8 slaves too?
https://codereview.chromium.org/11565044/diff/11001/masters/master.chromium.w... File masters/master.chromium.win/master_win_cfg.py (right): https://codereview.chromium.org/11565044/diff/11001/masters/master.chromium.w... masters/master.chromium.win/master_win_cfg.py:356: B('Win Aura', 'dbg_aura', 'compile|windows', 'win_dbg', On 2012/12/17 21:23:48, Peter Mayo wrote: > Win Aura Builder? Arg 1 needs to be distinct. Done. https://codereview.chromium.org/11565044/diff/11001/masters/master.chromium.w... File masters/master.chromium.win/slaves.cfg (right): https://codereview.chromium.org/11565044/diff/11001/masters/master.chromium.w... masters/master.chromium.win/slaves.cfg:313: 'builder': 'Win Aura', On 2012/12/17 21:23:48, Peter Mayo wrote: > 'builder': ['Win Aura Builder', 'Win Aura',], > > or allocate another slave Done. https://codereview.chromium.org/11565044/diff/11001/masters/master.tryserver.... File masters/master.tryserver.chromium/master.cfg (right): https://codereview.chromium.org/11565044/diff/11001/masters/master.tryserver.... masters/master.tryserver.chromium/master.cfg:1319: b_win_ash = CreateBuilder( On 2012/12/17 21:23:48, Peter Mayo wrote: > Should we move this to win8 slaves too? Yeah, that would make sense. I guess we'll need a new vm set up.
Don't forget there is sometimes some setup to getting the NFS or lighttpd running on the compile slave. Ask the trooper when restarting. LGTM - are we waiting on tryserver reassignment, or just going ahead?
Are you thinking you'll need to change all of the win_ash bots to be win8? Are those all shared with win_aura currently (which is win7)?
On 2012/12/20 19:26:57, Peter Mayo wrote: > Don't forget there is sometimes some setup to getting the NFS or lighttpd > running on the compile slave. Ask the trooper when restarting. OK, thanks. > LGTM - are we waiting on tryserver reassignment, or just going ahead? We might as well wait so they match. I'm going to be ooo, so I'll commit in Jan.
On 2012/12/20 19:30:58, cmp wrote: > Are you thinking you'll need to change all of the win_ash bots to be win8? Are > those all shared with win_aura currently (which is win7)? yes - win_ash = win_aura run on win8(metro) I learned that in comment #5. I am not against making this clearer by calling these "Aura (win7)" and "Aura (win8)" with try configs win_aura and win8_aura.
ptal: - tryserver now on win8 vm to match waterfall - rather than "aura" and "ash", renamed to "aura (win7)" and "aura (win8)".
LGTM https://codereview.chromium.org/11565044/diff/24001/masters/master.chromium.w... File masters/master.chromium.win/master_win_cfg.py (right): https://codereview.chromium.org/11565044/diff/24001/masters/master.chromium.w... masters/master.chromium.win/master_win_cfg.py:422: B('Win8 Ash', 'dbg_aura_win8', 'testers|windows', Won't it be easier to keep straight if the display name matches the "-b name" words? I.e. "Win8 Aura"
thanks https://codereview.chromium.org/11565044/diff/24001/masters/master.chromium.w... File masters/master.chromium.win/master_win_cfg.py (right): https://codereview.chromium.org/11565044/diff/24001/masters/master.chromium.w... masters/master.chromium.win/master_win_cfg.py:422: B('Win8 Ash', 'dbg_aura_win8', 'testers|windows', On 2013/01/09 17:50:20, Peter Mayo wrote: > Won't it be easier to keep straight if the display name matches the "-b name" > words? I.e. "Win8 Aura" Done.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11565044/30001
Presubmit check for 11565044-30001 failed and returned exit status 1.
Running presubmit commit checks ...
Running pylint on 281 files.
** Presubmit ERRORS **
test/masters_test.py failed!
Command test/masters_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/build
1 masters failed:
master.chromium.win
42 masters succeeded, 1 failed, 12 skipped in 151.7s.
Trying master.chromium
Trying master.chromium.chrome
Trying master.chromium.chromebot
Trying master.chromium.chromiumos
Trying master.chromium.endure
Trying master.chromium.flaky
Trying master.chromium.fyi
Trying master.chromium.git
Trying master.chromium.gpu
Trying master.chromium.gpu.fyi
Trying master.chromium.linux
Trying master.chromium.lkgr
Trying master.chromium.mac
Trying master.chromium.memory
Trying master.chromium.memory.fyi
Trying master.chromium.perf
Trying master.chromium.perf_av
Trying master.chromium.pyauto
Trying master.chromium.swarm
Trying master.chromium.webkit
Trying master.chromium.webrtc
Trying master.chromium.win
2013-01-09 10:16:01-0800 [-] Creating BuildMaster -- buildbot.version: 0.8.4p1
2013-01-09 10:16:01-0800 [-] loading configuration from
/b/commit-queue/workdir/tools/build/masters/master.chromium.win/master.cfg
2013-01-09 10:16:01-0800 [-] configuration update started
2013-01-09 10:16:02-0800 [-] unable to import dnotify, so Maildir will use
polling instead
2013-01-09 10:16:02-0800 [-] error while parsing config file
2013-01-09 10:16:02-0800 [-] Unhandled Error
Traceback (most recent call last):
File
"/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/master.py",
line 245, in loadTheConfigFile
d = self.loadConfig(f)
File
"/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/master.py",
line 597, in loadConfig
d.addCallback(do_load)
File
"/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/internet/defer.py",
line 297, in addCallback
callbackKeywords=kw)
File
"/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/internet/defer.py",
line 286, in addCallbacks
self._runCallbacks()
--- <exception caught here> ---
File
"/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/internet/defer.py",
line 542, in _runCallbacks
current.result = callback(current.result, *args, **kw)
File
"/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/master.py",
line 274, in do_load
exec f in localDict
File
"/b/commit-queue/workdir/tools/build/masters/master.chromium.win/master.cfg",
line 25, in <module>
import master_win_cfg
File
"/b/commit-queue/workdir/tools/build/masters/master.chromium.win/master_win_cfg.py",
line 436, in <module>
'generate_gtest_json': True}))
File
"/b/commit-queue/workdir/tools/build/scripts/master/factory/chromium_factory.py",
line 949, in ChromiumFactory
Trying master.chromiumos
Trying master.client.dart
Trying master.client.dart.fyi
Trying master.client.drmemory
Trying master.client.dynamorio
Trying master.client.nacl
Trying master.client.nacl.chrome
Trying master.client.nacl.llvm
Trying master.client.nacl.ports
Trying master.client.nacl.ragel
Trying master.client.nacl.sdk
Trying master.client.nacl.sdk.addin
Trying master.client.nacl.sdk.mono
Trying master.client.nacl.toolchain
Trying master.client.omaha
Trying master.client.pagespeed
Trying master.client.v8
Trying master.client.webrtc
Trying master.devtools
Trying master.tryserver.chromium
Trying master.tryserver.nacl
test/masters_cfg_test.py failed!
Command test/masters_cfg_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/tools/build
Parsing client.v8
Parsing chromium.endure
Parsing chromium.memory
Skipping chromium.swarm, fix and enable in masters_cfg_test.py!
Skipping client.nacl.chrome, fix and enable in masters_cfg_test.py!
Parsing experimental
Parsing chromium.win
error while parsing
/b/commit-queue/workdir/tools/build/masters/master.chromium.win/master.cfg:
Traceback (most recent call last):
File "/b/commit-queue/workdir/tools/build/scripts/common/master_cfg_utils.py",
line 76, in LoadConfig
localdict = ExecuteConfig(canonical_config)
File "/b/commit-queue/workdir/tools/build/scripts/common/master_cfg_utils.py",
line 50, in ExecuteConfig
exec f in localDict
File
"/b/commit-queue/workdir/tools/build/masters/master.chromium.win/master.cfg",
line 25, in <module>
import master_win_cfg
File
"/b/commit-queue/workdir/tools/build/masters/master.chromium.win/master_win_cfg.py",
line 436, in <module>
'generate_gtest_json': True}))
File
"/b/commit-queue/workdir/tools/build/scripts/master/factory/chromium_factory.py",
line 949, in ChromiumFactory
self._AddTests(chromium_cmd_obj, tests, mode, factory_properties)
File
"/b/commit-queue/workdir/tools/build/scripts/master/factory/chromium_factory.py",
line 836, in _AddTests
assert not tests, 'Did you make a typo? %s wasn\'t processed' % tests
AssertionError: Did you make a typo? ['view'] wasn't processed
build error encountered! aborting build
Parsing client.skia
Parsing chromium
Parsing client.sfntly
Parsing chromium.webrtc
Skipping client.dart.fyi, fix and enable in masters_cfg_test.py!
Parsing client.pagespeed
Parsing chromium.pyauto
Parsing tryserver.chromium
Parsing chromiumos.tryserver
cbuildbot_chromite not found! Returning empty config dictionary.
cbuildbot_chromite not found! Returning empty config dictionary.
Parsing client.dynamorio
Skipping client.syzygy, fix and enable in masters_cfg_test.py!
Parsing client.omaha
Parsing client.nacl.llvm
Parsing chromium.perf
Parsing chromium.memory.fyi
Parsing tryserver.nacl
Parsing chromium.webkit
Parsing client.nacl.sdk
Parsing chromium.linux
Parsing chromium.perf_av
Parsing chromium.gpu.fyi
Parsing chromium.chrome
Parsing chromiumos
Parsing client.nacl
Parsing client.nacl.toolchain
Parsing chromium.lkgr
Parsing client.nacl.sdk.mono
Parsing chromium.flaky
Parsing client.webrtc
Parsing client.nacl.ragel
Parsing chromium.fyi
Parsing devtools
Parsing client.nacl.sdk.addin
Parsing client.drmemory
Parsing chromium.mac
Skipping chromium.chromebot, fix and enable in masters_cfg_test.py!
Parsing chromium.gpu
Skipping client.dart, fix and enable in masters_cfg_test.py!
Parsing chromium.chromiumos
Parsing client.nacl.ports
Parsing chromium.git
The following master.cfgs did not load:
chromium.win: /b/commit-queue/workdir/tools/build/masters/master.chromium.win
Presubmit checks took 215.5s to calculate.
https://codereview.chromium.org/11565044/diff/30001/masters/master.tryserver.... File masters/master.tryserver.chromium/master.cfg (right): https://codereview.chromium.org/11565044/diff/30001/masters/master.tryserver.... masters/master.tryserver.chromium/master.cfg:1300: b_win_aura = CreateBuilder( Let's make this b_win7_aura. https://codereview.chromium.org/11565044/diff/30001/masters/master.tryserver.... masters/master.tryserver.chromium/master.cfg:1303: builder_name='win_aura (win7)', Let's make this win7_aura. https://codereview.chromium.org/11565044/diff/30001/masters/master.tryserver.... masters/master.tryserver.chromium/master.cfg:1326: b_win_aura_win8 = CreateBuilder( Let's make this b_win8_aura. https://codereview.chromium.org/11565044/diff/30001/masters/master.tryserver.... masters/master.tryserver.chromium/master.cfg:1329: builder_name='win_aura (win8)', Let's make this win8_aura. https://codereview.chromium.org/11565044/diff/30001/masters/master.tryserver.... File masters/master.tryserver.chromium/slaves.cfg (right): https://codereview.chromium.org/11565044/diff/30001/masters/master.tryserver.... masters/master.tryserver.chromium/slaves.cfg:386: aura7_slaves = [ Let's name this win7_aura_slaves. https://codereview.chromium.org/11565044/diff/30001/masters/master.tryserver.... masters/master.tryserver.chromium/slaves.cfg:390: 'win_aura (win7)', Corresponding change to win7_aura here https://codereview.chromium.org/11565044/diff/30001/masters/master.tryserver.... masters/master.tryserver.chromium/slaves.cfg:399: aura8_slaves = [ Let's name this win8_aura_slaves. https://codereview.chromium.org/11565044/diff/30001/masters/master.tryserver.... masters/master.tryserver.chromium/slaves.cfg:403: 'win_aura (win8)', corresponding change to win8_aura here
These changes will require a CQ change, BTW.
thanks https://chromiumcodereview.appspot.com/11565044/diff/30001/masters/master.try... File masters/master.tryserver.chromium/master.cfg (right): https://chromiumcodereview.appspot.com/11565044/diff/30001/masters/master.try... masters/master.tryserver.chromium/master.cfg:1300: b_win_aura = CreateBuilder( On 2013/01/09 18:47:54, cmp wrote: > Let's make this b_win7_aura. Done. https://chromiumcodereview.appspot.com/11565044/diff/30001/masters/master.try... masters/master.tryserver.chromium/master.cfg:1303: builder_name='win_aura (win7)', On 2013/01/09 18:47:54, cmp wrote: > Let's make this win7_aura. Done. https://chromiumcodereview.appspot.com/11565044/diff/30001/masters/master.try... masters/master.tryserver.chromium/master.cfg:1326: b_win_aura_win8 = CreateBuilder( On 2013/01/09 18:47:54, cmp wrote: > Let's make this b_win8_aura. Done. https://chromiumcodereview.appspot.com/11565044/diff/30001/masters/master.try... masters/master.tryserver.chromium/master.cfg:1329: builder_name='win_aura (win8)', On 2013/01/09 18:47:54, cmp wrote: > Let's make this win8_aura. Done. https://chromiumcodereview.appspot.com/11565044/diff/30001/masters/master.try... File masters/master.tryserver.chromium/slaves.cfg (right): https://chromiumcodereview.appspot.com/11565044/diff/30001/masters/master.try... masters/master.tryserver.chromium/slaves.cfg:386: aura7_slaves = [ On 2013/01/09 18:47:54, cmp wrote: > Let's name this win7_aura_slaves. Done. https://chromiumcodereview.appspot.com/11565044/diff/30001/masters/master.try... masters/master.tryserver.chromium/slaves.cfg:390: 'win_aura (win7)', On 2013/01/09 18:47:54, cmp wrote: > Corresponding change to win7_aura here Done. https://chromiumcodereview.appspot.com/11565044/diff/30001/masters/master.try... masters/master.tryserver.chromium/slaves.cfg:399: aura8_slaves = [ On 2013/01/09 18:47:54, cmp wrote: > Let's name this win8_aura_slaves. Done. https://chromiumcodereview.appspot.com/11565044/diff/30001/masters/master.try... masters/master.tryserver.chromium/slaves.cfg:403: 'win_aura (win8)', On 2013/01/09 18:47:54, cmp wrote: > corresponding change to win8_aura here Done.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11565044/36001
Message was sent while issue was closed.
Change committed as 175844
Message was sent while issue was closed.
On 2013/01/09 19:04:28, I haz the power (commit-bot) wrote: > Change committed as 175844 The CQ ... :(
Message was sent while issue was closed.
On 2013/01/11 13:40:54, Marc-Antoine Ruel wrote: > On 2013/01/09 19:04:28, I haz the power (commit-bot) wrote: > > Change committed as 175844 > > The CQ ... :( Sorry, I guess I misunderstood cmp's comment. Did something break/did you revert? |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
