dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart - Issue 11565034: Improve performance of dart2js StringBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 11565034: Improve performance of dart2js StringBuffer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Updated to lib_v2 and private libraries. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart b/dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

index 94fd88763ca0986236931924e7caab2dabe5da2b..1014f047542f1e7c1666ef7752768e05f228991f 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

@@ -37,6 +37,11 @@ checkGrowable(list, reason) {

}

String S(value) {

+ if (value is String) return value;

+ if ((value is num && value != 0) || value is bool) {

+ return JS('String', r'String(#)', value);

+ }

+ if (value == null) return 'null';

var res = value.toString();

if (res is !String) throw new ArgumentError(value);

return res;