Issue 1156503007: Merge to M44: An accessibility tree update with two roots should be rejected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156503007: Merge to M44: An accessibility tree update with two roots should be rejected. (Closed)

Created:
5 years, 6 months ago by dmazzoni

Modified:
5 years, 6 months ago

Reviewers:

CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2403

Target Ref:
refs/pending/branch-heads/2403

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge to M44: An accessibility tree update with two roots should be rejected. If an AXTreeUpdate had two root nodes, the second one would cause the first one to be deleted, but that could leave dangling pointers in |pending_nodes|. Fix this by first ensuring that |pending_nodes| is always cleaned up when nodse are deleted, but also by specifically returning an error if we encounter two root nodes since that should never happen. BUG=479743 Review URL: https://codereview.chromium.org/1151393006 Cr-Commit-Position: refs/heads/master@{#332212} (cherry picked from commit e3b7faf115bcd4fec56b1658e60abe077d77f379)

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -19 lines)			Patch
M	ui/accessibility/ax_tree.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	ui/accessibility/ax_tree.cc	View	9 chunks	+31 lines, -16 lines	0 comments	Download
M	ui/accessibility/ax_tree_unittest.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

5 years, 6 months ago (2015-06-04 21:25:35 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
3d6172b44f285cbdd661e425c382f895c9457907.

Expand Messages | Collapse Messages