Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2024)

Unified Diff: content/renderer/browser_plugin/browser_plugin_manager_impl.h

Issue 11565024: Browser Plugin: Reduce code repetition in BrowserPluginManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use switch statement instead of set. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_manager_impl.h
diff --git a/content/renderer/browser_plugin/browser_plugin_manager_impl.h b/content/renderer/browser_plugin/browser_plugin_manager_impl.h
index b217cc591565ec0dbe7d73236e2418aaa53253a0..eb69591ca29ef2c1546e9027f855f49f0c5e4a57 100644
--- a/content/renderer/browser_plugin/browser_plugin_manager_impl.h
+++ b/content/renderer/browser_plugin/browser_plugin_manager_impl.h
@@ -8,7 +8,6 @@
#include "content/renderer/browser_plugin/browser_plugin_manager.h"
#include "googleurl/src/gurl.h"
-struct BrowserPluginMsg_LoadCommit_Params;
struct BrowserPluginMsg_UpdateRect_Params;
class WebCursor;
@@ -36,34 +35,12 @@ class BrowserPluginManagerImpl : public BrowserPluginManager {
private:
virtual ~BrowserPluginManagerImpl();
- void OnUpdateRect(int instance_id,
- int message_id,
- const BrowserPluginMsg_UpdateRect_Params& params);
- void OnGuestGone(int instance_id, int process_id, int status);
- void OnAdvanceFocus(int instance_id, bool reverse);
- void OnGuestContentWindowReady(int instance_id, int guest_routing_id);
- void OnShouldAcceptTouchEvents(int instance_id, bool accept);
- void OnLoadStart(int instance_id,
- const GURL& url,
- bool is_top_level);
- void OnLoadCommit(int instance_id,
- const BrowserPluginMsg_LoadCommit_Params& params);
- void OnLoadStop(int instance_id);
- void OnLoadAbort(int instance_id,
- const GURL& url,
- bool is_top_level,
- const std::string& type);
- void OnLoadRedirect(int instance_id,
- const GURL& old_url,
- const GURL& new_url,
- bool is_top_level);
- void OnSetCursor(int instance_id,
- const WebCursor& cursor);
void OnPluginAtPositionRequest(const IPC::Message& message,
int request_id,
const gfx::Point& position);
- void OnGuestUnresponsive(int instance_id, int process_id);
- void OnGuestResponsive(int instance_id, int process_id);
+
+ // Returns whether a message should be forwarded to BrowserPlugins.
+ static bool ShouldForwardToBrowserPlugin(const IPC::Message& message);
DISALLOW_COPY_AND_ASSIGN(BrowserPluginManagerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698