Browser Plugin: Reduce code repetition in BrowserPluginManager.

content/renderer/browser_plugin/browser_plugin_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin_browsertest.h"
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/singleton.h"
 #include "base/path_service.h"
@@ skipping 109 matching lines @@
 // This test verifies that an initial resize occurs when we instantiate the
 // browser plugin. This test also verifies that the browser plugin is waiting
 // for a BrowserPluginMsg_UpdateRect in response. We issue an UpdateRect, and
 // we observe an UpdateRect_ACK, with the |pending_damage_buffer_| reset,
 // indiciating that the BrowserPlugin is not waiting for any more UpdateRects to
 // satisfy its resize request.
 TEST_F(BrowserPluginTest, InitialResize) {
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
   // Verify that the information based on ResizeGuest is correct, and
   // use its TransportDIB::Id to paint.
-  const IPC::Message* msg =
-      browser_plugin_manager()->sink().GetUniqueMessageMatching(
-          BrowserPluginHostMsg_ResizeGuest::ID);
-  ASSERT_TRUE(msg);
-  int instance_id = -1;
-  BrowserPluginHostMsg_ResizeGuest_Params params;
-  BrowserPluginHostMsg_ResizeGuest::Read(msg, &instance_id, &params);
-  EXPECT_EQ(640, params.view_size.width());
-  EXPECT_EQ(480, params.view_size.height());
+  int instance_id = 0;
+  {
+    const IPC::Message* msg =
+        browser_plugin_manager()->sink().GetUniqueMessageMatching(
+            BrowserPluginHostMsg_ResizeGuest::ID);
+    ASSERT_TRUE(msg);
+    BrowserPluginHostMsg_ResizeGuest_Params params;
+    BrowserPluginHostMsg_ResizeGuest::Read(msg, &instance_id, &params);
+    EXPECT_EQ(640, params.view_size.width());
+    EXPECT_EQ(480, params.view_size.height());
+  }
 
   MockBrowserPlugin* browser_plugin =
       static_cast<MockBrowserPlugin*>(
           browser_plugin_manager()->GetBrowserPlugin(instance_id));
   ASSERT_TRUE(browser_plugin);
   // Now the browser plugin is expecting a UpdateRect resize.
   EXPECT_TRUE(browser_plugin->pending_damage_buffer_);
 
   // Send the BrowserPlugin an UpdateRect equal to its container size with
   // the same damage buffer. That should clear |pending_damage_buffer_|.
   BrowserPluginMsg_UpdateRect_Params update_rect_params;
   update_rect_params.damage_buffer_identifier =
 #if defined(OS_MACOSX)
         browser_plugin->pending_damage_buffer_->id();
 #else
         browser_plugin->pending_damage_buffer_->handle();
 #endif
   update_rect_params.view_size = gfx::Size(640, 480);
   update_rect_params.scale_factor = 1.0f;
   update_rect_params.is_resize_ack = true;
-  browser_plugin->UpdateRect(0, update_rect_params);
+  BrowserPluginMsg_UpdateRect msg(0, instance_id, 0, update_rect_params);
+  browser_plugin->OnMessageReceived(msg);
   EXPECT_FALSE(browser_plugin->pending_damage_buffer_);
 }
 
 // Verify that the src attribute on the browser plugin works as expected.
 TEST_F(BrowserPluginTest, SrcAttribute) {
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
   // Verify that we're reporting the correct URL to navigate to based on the
   // src attribute.
   {
     // Ensure we get a CreateGuest on the initial navigation.
     const IPC::Message* create_msg =
     browser_plugin_manager()->sink().GetUniqueMessageMatching(
         BrowserPluginHostMsg_CreateGuest::ID);
     ASSERT_TRUE(create_msg);
 
     const IPC::Message* msg =
     browser_plugin_manager()->sink().GetUniqueMessageMatching(
         BrowserPluginHostMsg_NavigateGuest::ID);
     ASSERT_TRUE(msg);
 
-    int instance_id = -1;
+    int instance_id = 0;
     std::string src;
     BrowserPluginHostMsg_NavigateGuest::Read(msg, &instance_id, &src);
     EXPECT_EQ("foo", src);
   }
 
   browser_plugin_manager()->sink().ClearMessages();
   // Navigate to bar and observe the associated
   // BrowserPluginHostMsg_NavigateGuest message.
   // Verify that the src attribute is updated as well.
   ExecuteJavaScript("document.getElementById('browserplugin').src = 'bar'");
   {
     // Verify that we do not get a CreateGuest on subsequent navigations.
     const IPC::Message* create_msg =
     browser_plugin_manager()->sink().GetUniqueMessageMatching(
         BrowserPluginHostMsg_CreateGuest::ID);
     ASSERT_FALSE(create_msg);
 
     const IPC::Message* msg =
       browser_plugin_manager()->sink().GetUniqueMessageMatching(
           BrowserPluginHostMsg_NavigateGuest::ID);
     ASSERT_TRUE(msg);
 
-    int instance_id = -1;
+    int instance_id = 0;
     std::string src;
     BrowserPluginHostMsg_NavigateGuest::Read(msg, &instance_id, &src);
     EXPECT_EQ("bar", src);
     std::string src_value =
         ExecuteScriptAndReturnString(
             "document.getElementById('browserplugin').src");
     EXPECT_EQ("bar", src_value);
   }
 }
 
 TEST_F(BrowserPluginTest, ResizeFlowControl) {
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
-  int instance_id = -1;
+  int instance_id = 0;
   {
     // Ensure we get a NavigateGuest on the initial navigation and grab the
     // BrowserPlugin's instance_id from there.
     std::string src;
     const IPC::Message* nav_msg =
     browser_plugin_manager()->sink().GetUniqueMessageMatching(
         BrowserPluginHostMsg_NavigateGuest::ID);
     ASSERT_TRUE(nav_msg);
     BrowserPluginHostMsg_NavigateGuest::Read(nav_msg, &instance_id, &src);
   }
@@ skipping 12 matching lines @@
     update_rect_params.is_resize_ack = true;
     // By sending the damage buffer handle back to BrowserPlugin on UpdateRect,
     // then the BrowserPlugin knows that the browser process has received and
     // has begun to use the pending_damage_buffer.
     update_rect_params.damage_buffer_identifier =
 #if defined(OS_MACOSX)
         browser_plugin->pending_damage_buffer_->id();
 #else
         browser_plugin->pending_damage_buffer_->handle();
 #endif
-    browser_plugin->UpdateRect(0, update_rect_params);
+    BrowserPluginMsg_UpdateRect msg(0, instance_id, 0, update_rect_params);
+    browser_plugin->OnMessageReceived(msg);
     EXPECT_EQ(NULL, browser_plugin->pending_damage_buffer_);
   }
 
   browser_plugin_manager()->sink().ClearMessages();
 
   // Resize the browser plugin three times.
   ExecuteJavaScript("document.getElementById('browserplugin').width = '641px'");
   ProcessPendingMessages();
   ExecuteJavaScript("document.getElementById('browserplugin').width = '642px'");
   ProcessPendingMessages();
@@ skipping 21 matching lines @@
     BrowserPluginMsg_UpdateRect_Params update_rect_params;
     update_rect_params.view_size = gfx::Size(641, 480);
     update_rect_params.scale_factor = 1.0f;
     update_rect_params.is_resize_ack = true;
     update_rect_params.damage_buffer_identifier =
 #if defined(OS_MACOSX)
         browser_plugin->pending_damage_buffer_->id();
 #else
         browser_plugin->pending_damage_buffer_->handle();
 #endif
-    browser_plugin->UpdateRect(0, update_rect_params);
+    BrowserPluginMsg_UpdateRect msg(0, instance_id, 0, update_rect_params);
+    browser_plugin->OnMessageReceived(msg);
     // This tells us that the BrowserPlugin is still expecting another
     // UpdateRect with the most recent size.
     EXPECT_TRUE(browser_plugin->pending_damage_buffer_);
   }
   // Send the BrowserPlugin another UpdateRect, but this time with a size
   // that matches the size of the container.
   {
     BrowserPluginMsg_UpdateRect_Params update_rect_params;
     update_rect_params.view_size = gfx::Size(643, 480);
     update_rect_params.scale_factor = 1.0f;
     update_rect_params.is_resize_ack = true;
     update_rect_params.damage_buffer_identifier =
 #if defined(OS_MACOSX)
         browser_plugin->pending_damage_buffer_->id();
 #else
         browser_plugin->pending_damage_buffer_->handle();
 #endif
-    browser_plugin->UpdateRect(0, update_rect_params);
+    BrowserPluginMsg_UpdateRect msg(0, instance_id, 0, update_rect_params);
+    browser_plugin->OnMessageReceived(msg);
     // The BrowserPlugin has finally received an UpdateRect that satisifes
     // its current size, and so it is happy.
     EXPECT_FALSE(browser_plugin->pending_damage_buffer_);
   }
 }
 
 TEST_F(BrowserPluginTest, GuestCrash) {
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
 
   // Grab the BrowserPlugin's instance ID from its resize message.
-  const IPC::Message* msg =
-      browser_plugin_manager()->sink().GetFirstMessageMatching(
-          BrowserPluginHostMsg_ResizeGuest::ID);
-  ASSERT_TRUE(msg);
-  int instance_id = -1;
-  BrowserPluginHostMsg_ResizeGuest_Params params;
-  BrowserPluginHostMsg_ResizeGuest::Read(msg, &instance_id, &params);
-
+  int instance_id = 0;
+  {
+    const IPC::Message* msg =
+        browser_plugin_manager()->sink().GetFirstMessageMatching(
+            BrowserPluginHostMsg_ResizeGuest::ID);
+    ASSERT_TRUE(msg);
+    BrowserPluginHostMsg_ResizeGuest_Params params;
+    BrowserPluginHostMsg_ResizeGuest::Read(msg, &instance_id, &params);
+  }
   MockBrowserPlugin* browser_plugin =
       static_cast<MockBrowserPlugin*>(
           browser_plugin_manager()->GetBrowserPlugin(instance_id));
   ASSERT_TRUE(browser_plugin);
 
   WebKit::WebCursorInfo cursor_info;
   // Send an event and verify that the event is deported.
   browser_plugin->handleInputEvent(WebKit::WebMouseEvent(),
                                    cursor_info);
   EXPECT_TRUE(browser_plugin_manager()->sink().GetUniqueMessageMatching(
       BrowserPluginHostMsg_HandleInputEvent::ID));
   browser_plugin_manager()->sink().ClearMessages();
 
   const char* kAddEventListener =
     "var msg;"
     "function exitListener(e) {"
     "  msg = JSON.parse(e.detail).reason;"
     "}"
     "document.getElementById('browserplugin')."
     "    addEventListener('-internal-exit', exitListener);";
 
   ExecuteJavaScript(kAddEventListener);
 
   // Pretend that the guest has terminated normally.
-  browser_plugin->GuestGone(0, base::TERMINATION_STATUS_NORMAL_TERMINATION);
+  {
+    BrowserPluginMsg_GuestGone msg(
+        0, 0, 0, base::TERMINATION_STATUS_NORMAL_TERMINATION);
+    browser_plugin->OnMessageReceived(msg);
+  }
 
   // Verify that our event listener has fired.
   EXPECT_EQ("normal", ExecuteScriptAndReturnString("msg"));
 
   // Pretend that the guest has crashed.
-  browser_plugin->GuestGone(0, base::TERMINATION_STATUS_PROCESS_CRASHED);
+  {
+    BrowserPluginMsg_GuestGone msg(
+        0, 0, 0, base::TERMINATION_STATUS_PROCESS_CRASHED);
+    browser_plugin->OnMessageReceived(msg);
+  }
 
   // Verify that our event listener has fired.
   EXPECT_EQ("crashed", ExecuteScriptAndReturnString("msg"));
 
   // Send an event and verify that events are no longer deported.
   browser_plugin->handleInputEvent(WebKit::WebMouseEvent(),
                                    cursor_info);
   EXPECT_FALSE(browser_plugin_manager()->sink().GetUniqueMessageMatching(
       BrowserPluginHostMsg_HandleInputEvent::ID));
 }
@@ skipping 27 matching lines @@
   const char* kGoogleURL = "http://www.google.com/";
   const char* kGoogleNewsURL = "http://news.google.com/";
 
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
   ExecuteJavaScript(kAddEventListener);
   // Grab the BrowserPlugin's instance ID from its resize message.
   const IPC::Message* msg =
       browser_plugin_manager()->sink().GetFirstMessageMatching(
           BrowserPluginHostMsg_ResizeGuest::ID);
   ASSERT_TRUE(msg);
-  int instance_id = -1;
+  int instance_id = 0;
   BrowserPluginHostMsg_ResizeGuest_Params params;
   BrowserPluginHostMsg_ResizeGuest::Read(msg, &instance_id, &params);
 
   MockBrowserPlugin* browser_plugin =
       static_cast<MockBrowserPlugin*>(
           browser_plugin_manager()->GetBrowserPlugin(instance_id));
   ASSERT_TRUE(browser_plugin);
 
   {
     BrowserPluginMsg_LoadCommit_Params navigate_params;
     navigate_params.is_top_level = true;
     navigate_params.url = GURL(kGoogleURL);
     navigate_params.process_id = 1337;
-    browser_plugin->LoadCommit(navigate_params);
+    BrowserPluginMsg_LoadCommit msg(0, instance_id, navigate_params);
+    browser_plugin->OnMessageReceived(msg);
     EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString("url"));
     EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString(kGetSrc));
     EXPECT_EQ(1337, ExecuteScriptAndReturnInt(kGetProcessID));
   }
   ExecuteJavaScript(kRemoveEventListener);
   {
     BrowserPluginMsg_LoadCommit_Params navigate_params;
     navigate_params.is_top_level = false;
     navigate_params.url = GURL(kGoogleNewsURL);
     navigate_params.process_id = 42;
-    browser_plugin->LoadCommit(navigate_params);
+    BrowserPluginMsg_LoadCommit msg(0, instance_id, navigate_params);
+    browser_plugin->OnMessageReceived(msg);
     // The URL variable should not change because we've removed the event
     // listener.
     EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString("url"));
     // The src attribute should not change if this is a top-level navigation.
     EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString(kGetSrc));
     EXPECT_EQ(42, ExecuteScriptAndReturnInt(kGetProcessID));
   }
 }
 
 TEST_F(BrowserPluginTest, StopMethod) {
@@ skipping 121 matching lines @@
       "document.getElementById('browserplugin').src");
   EXPECT_STREQ("", src_value.c_str());
 
   ExecuteJavaScript("document.getElementById('browserplugin').src = 'bar'");
   {
     const IPC::Message* create_msg =
     browser_plugin_manager()->sink().GetUniqueMessageMatching(
         BrowserPluginHostMsg_CreateGuest::ID);
     ASSERT_TRUE(create_msg);
 
-    int create_instance_id = -1;
+    int create_instance_id = 0;
     BrowserPluginHostMsg_CreateGuest_Params params;
     BrowserPluginHostMsg_CreateGuest::Read(
         create_msg,
         &create_instance_id,
         &params);
     EXPECT_STREQ("storage", params.storage_partition_id.c_str());
     EXPECT_FALSE(params.persist_storage);
 
     const IPC::Message* msg =
         browser_plugin_manager()->sink().GetUniqueMessageMatching(
             BrowserPluginHostMsg_NavigateGuest::ID);
     ASSERT_TRUE(msg);
 
-    int instance_id = -1;
+    int instance_id = 0;
     std::string src;
     BrowserPluginHostMsg_NavigateGuest::Read(msg, &instance_id, &src);
     EXPECT_STREQ("bar", src.c_str());
     EXPECT_EQ(create_instance_id, instance_id);
   }
 
   // Setting the partition should throw an exception and the value should not
   // change.
   ExecuteJavaScript(
       "try {"
@@ skipping 28 matching lines @@
   const char* kGetProcessID =
       "document.getElementById('browserplugin').getProcessId()";
 
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
   ExecuteJavaScript(kAddEventListener);
   // Grab the BrowserPlugin's instance ID from its resize message.
   const IPC::Message* msg =
       browser_plugin_manager()->sink().GetFirstMessageMatching(
           BrowserPluginHostMsg_ResizeGuest::ID);
   ASSERT_TRUE(msg);
-  int instance_id = -1;
+  int instance_id = 0;
   BrowserPluginHostMsg_ResizeGuest_Params params;
   BrowserPluginHostMsg_ResizeGuest::Read(msg, &instance_id, &params);
 
   MockBrowserPlugin* browser_plugin =
       static_cast<MockBrowserPlugin*>(
           browser_plugin_manager()->GetBrowserPlugin(instance_id));
   ASSERT_TRUE(browser_plugin);
 
   {
     BrowserPluginMsg_LoadCommit_Params navigate_params;
     navigate_params.url = GURL(kGoogleURL);
     navigate_params.process_id = 1337;
-    browser_plugin->LoadCommit(navigate_params);
+    BrowserPluginMsg_LoadCommit msg(0, instance_id, navigate_params);
+    browser_plugin->OnMessageReceived(msg);
     EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString("url"));
     EXPECT_EQ(1337, ExecuteScriptAndReturnInt(kGetProcessID));
   }
   {
     BrowserPluginMsg_LoadCommit_Params navigate_params;
     navigate_params.url = GURL(kGoogleNewsURL);
     navigate_params.process_id = 42;
-    browser_plugin->LoadCommit(navigate_params);
+    BrowserPluginMsg_LoadCommit msg(0, instance_id, navigate_params);
+    browser_plugin->OnMessageReceived(msg);
     // The URL variable should not change because we've removed the event
     // listener.
     EXPECT_EQ(kGoogleURL, ExecuteScriptAndReturnString("url"));
     EXPECT_EQ(42, ExecuteScriptAndReturnInt(kGetProcessID));
   }
 }
 
 // This test verifies that multiple event listeners fire that are registered
 // on a single event type.
 TEST_F(BrowserPluginTest, MultipleEventListeners) {
@@ skipping 13 matching lines @@
   const char* kGetProcessID =
       "document.getElementById('browserplugin').getProcessId()";
 
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
   ExecuteJavaScript(kAddEventListener);
   // Grab the BrowserPlugin's instance ID from its resize message.
   const IPC::Message* msg =
       browser_plugin_manager()->sink().GetFirstMessageMatching(
           BrowserPluginHostMsg_ResizeGuest::ID);
   ASSERT_TRUE(msg);
-  int instance_id = -1;
+  int instance_id = 0;
   BrowserPluginHostMsg_ResizeGuest_Params params;
   BrowserPluginHostMsg_ResizeGuest::Read(msg, &instance_id, &params);
 
   MockBrowserPlugin* browser_plugin =
       static_cast<MockBrowserPlugin*>(
           browser_plugin_manager()->GetBrowserPlugin(instance_id));
   ASSERT_TRUE(browser_plugin);
 
   {
     BrowserPluginMsg_LoadCommit_Params navigate_params;
     navigate_params.url = GURL(kGoogleURL);
     navigate_params.process_id = 1337;
-    browser_plugin->LoadCommit(navigate_params);
+    BrowserPluginMsg_LoadCommit msg(0, instance_id, navigate_params);
+    browser_plugin->OnMessageReceived(msg);
     EXPECT_EQ(2, ExecuteScriptAndReturnInt("count"));
     EXPECT_EQ(1337, ExecuteScriptAndReturnInt(kGetProcessID));
   }
 }
 
 TEST_F(BrowserPluginTest, RemoveBrowserPluginOnExit) {
   LoadHTML(GetHTMLForBrowserPluginObject().c_str());
 
   // Grab the BrowserPlugin's instance ID from its resize message.
-  const IPC::Message* msg =
-      browser_plugin_manager()->sink().GetFirstMessageMatching(
-          BrowserPluginHostMsg_ResizeGuest::ID);
-  ASSERT_TRUE(msg);
-  int instance_id = -1;
-  BrowserPluginHostMsg_ResizeGuest_Params params;
-  BrowserPluginHostMsg_ResizeGuest::Read(msg, &instance_id, &params);
+  int instance_id = 0;
+  {
+    const IPC::Message* msg =
+        browser_plugin_manager()->sink().GetFirstMessageMatching(
+            BrowserPluginHostMsg_ResizeGuest::ID);
+    ASSERT_TRUE(msg);
+    BrowserPluginHostMsg_ResizeGuest_Params params;
+    BrowserPluginHostMsg_ResizeGuest::Read(msg, &instance_id, &params);
+  }
 
   MockBrowserPlugin* browser_plugin =
       static_cast<MockBrowserPlugin*>(
           browser_plugin_manager()->GetBrowserPlugin(instance_id));
   ASSERT_TRUE(browser_plugin);
 
   const char* kAddEventListener =
     "function exitListener(e) {"
     "  if (JSON.parse(e.detail).reason == 'killed') {"
     "    var bp = document.getElementById('browserplugin');"
     "    bp.parentNode.removeChild(bp);"
     "  }"
     "}"
     "document.getElementById('browserplugin')."
     "    addEventListener('-internal-exit', exitListener);";
 
   ExecuteJavaScript(kAddEventListener);
 
   // Pretend that the guest has crashed.
-  browser_plugin->GuestGone(0, base::TERMINATION_STATUS_PROCESS_WAS_KILLED);
+  BrowserPluginMsg_GuestGone msg(
+      0, instance_id, 0, base::TERMINATION_STATUS_PROCESS_WAS_KILLED);
+  browser_plugin->OnMessageReceived(msg);
 
   ProcessPendingMessages();
 
   EXPECT_EQ(NULL, browser_plugin_manager()->GetBrowserPlugin(instance_id));
 }
 
 TEST_F(BrowserPluginTest, AutoSizeAttributes) {
   std::string html = StringPrintf(kHTMLForSourcelessPluginObject,
                                   content::kBrowserPluginMimeType);
   LoadHTML(html.c_str());
   const char* kSetAutoSizeParametersAndNavigate =
     "var browserplugin = document.getElementById('browserplugin');"
     "browserplugin.autoSize = true;"
     "browserplugin.minWidth = 42;"
     "browserplugin.minHeight = 43;"
     "browserplugin.maxWidth = 1337;"
     "browserplugin.maxHeight = 1338;"
     "browserplugin.src = 'foobar';";
   const char* kDisableAutoSize =
     "document.getElementById('browserplugin').autoSize = false;";
 
-  int instance_id = -1;
+  int instance_id = 0;
   // Set some autosize parameters before navigating then navigate.
   // Verify that the BrowserPluginHostMsg_CreateGuest message contains
   // the correct autosize parameters.
   ExecuteJavaScript(kSetAutoSizeParametersAndNavigate);
   ProcessPendingMessages();
   {
     const IPC::Message* create_msg =
     browser_plugin_manager()->sink().GetUniqueMessageMatching(
         BrowserPluginHostMsg_CreateGuest::ID);
     ASSERT_TRUE(create_msg);
@@ skipping 30 matching lines @@
   BrowserPluginMsg_UpdateRect_Params update_rect_params;
   update_rect_params.damage_buffer_identifier =
 #if defined(OS_MACOSX)
         browser_plugin->pending_damage_buffer_->id();
 #else
         browser_plugin->pending_damage_buffer_->handle();
 #endif
   update_rect_params.view_size = gfx::Size(1337, 1338);
   update_rect_params.scale_factor = 1.0f;
   update_rect_params.is_resize_ack = true;
-  browser_plugin->UpdateRect(0, update_rect_params);
+  BrowserPluginMsg_UpdateRect msg(0, instance_id, 0, update_rect_params);
+  browser_plugin->OnMessageReceived(msg);
 
   // Verify that the autosize state has been updated.
   {
     const IPC::Message* auto_size_msg =
     browser_plugin_manager()->sink().GetUniqueMessageMatching(
         BrowserPluginHostMsg_UpdateRect_ACK::ID);
     ASSERT_TRUE(auto_size_msg);
 
-    int instance_id = -1;
+    int instance_id = 0;
     int message_id = 0;
     BrowserPluginHostMsg_AutoSize_Params auto_size_params;
     BrowserPluginHostMsg_ResizeGuest_Params resize_params;
     BrowserPluginHostMsg_UpdateRect_ACK::Read(auto_size_msg,
                                               &instance_id,
                                               &message_id,
                                               &auto_size_params,
                                               &resize_params);
     EXPECT_FALSE(auto_size_params.enable);
     EXPECT_EQ(42, auto_size_params.min_size.width());
     EXPECT_EQ(43, auto_size_params.min_size.height());
     EXPECT_EQ(1337, auto_size_params.max_size.width());
     EXPECT_EQ(1338, auto_size_params.max_size.height());
   }
 }
 
 }  // namespace content