Add API to route end of fling messages from WebLayerTreeView to InputHandler

Add API to route end of fling messages from WebLayerTreeView to InputHandler

This API will be used by WebViewImpl to send end of fling messages to the
compositor. Then the compositor will only send flingCancels if there is a
main thread fling. This flingCancels when unnecessarily sent are causing
a lot of input lag when main thread is blocked.

BUG=162767
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173492

[Yusuf, 2012-12-13 21:31:22]

I will also be uploading the WebKit change that makes use of the added API.

[jamesr, 2012-12-13 21:39:05]

lgtm % nits

I'd really like this routing to be easier

https://codereview.chromium.org/11565022/diff/1/cc/single_thread_proxy.h
File cc/single_thread_proxy.h (right):

https://codereview.chromium.org/11565022/diff/1/cc/single_thread_proxy.h#newc...
cc/single_thread_proxy.h:43: virtual void mainThreadHasStoppedFlinging()
OVERRIDE { };
nit: no trailing semicolon

https://codereview.chromium.org/11565022/diff/1/cc/thread_proxy.cc
File cc/thread_proxy.cc (right):

https://codereview.chromium.org/11565022/diff/1/cc/thread_proxy.cc#newcode436
cc/thread_proxy.cc:436: if (m_inputHandlerOnImplThread.get())
nits:

- just "if (m_inputHandlerOnImplThread)" will do the right thing
- this file is still WebKit style, so 4-space indents

[jamesr1, 2012-12-13 21:39:45]

On Thu, Dec 13, 2012 at 1:39 PM, <jamesr@chromium.org> wrote:

> lgtm % nits
>
> I'd really like this routing to be easier
>

FYI this is a note for myself - I'm not asking you to redesign this mess :)


>
>
> https://codereview.chromium.**org/11565022/diff/1/cc/single_**
>
thread_proxy.h<https://codereview.chromium.org/11565022/diff/1/cc/single_thread_proxy.h>
> File cc/single_thread_proxy.h (right):
>
> https://codereview.chromium.**org/11565022/diff/1/cc/single_**
>
thread_proxy.h#newcode43<https://codereview.chromium.org/11565022/diff/1/cc/single_thread_proxy.h#newcode43>
> cc/single_thread_proxy.h:43: virtual void mainThreadHasStoppedFlinging()
> OVERRIDE { };
> nit: no trailing semicolon
>
>
https://codereview.chromium.**org/11565022/diff/1/cc/thread_**proxy.cc<https:...
> File cc/thread_proxy.cc (right):
>
> https://codereview.chromium.**org/11565022/diff/1/cc/thread_**
>
proxy.cc#newcode436<https://codereview.chromium.org/11565022/diff/1/cc/thread_proxy.cc#newcode436>
> cc/thread_proxy.cc:436: if (m_inputHandlerOnImplThread.**get())
> nits:
>
> - just "if (m_inputHandlerOnImplThread)" will do the right thing
> - this file is still WebKit style, so 4-space indents
>
>
https://codereview.chromium.**org/11565022/<https://codereview.chromium.org/1...
>

[Yusuf, 2012-12-13 22:00:47]

On 2012/12/13 21:39:45, jamesr1 wrote:
> On Thu, Dec 13, 2012 at 1:39 PM, <mailto:jamesr@chromium.org> wrote:
> 
> > lgtm % nits
> >
> > I'd really like this routing to be easier
> >
> 
> FYI this is a note for myself - I'm not asking you to redesign this mess :)

:) It pains me to be uploading this too. I can volunteer to make it possible to
use a shorter path after m25 cut, if/when you have a plan in mind.

[Yusuf, 2012-12-13 22:01:01]

Done.

On 2012/12/13 21:39:05, jamesr wrote:
> lgtm % nits
> 
> I'd really like this routing to be easier
> 
> https://codereview.chromium.org/11565022/diff/1/cc/single_thread_proxy.h
> File cc/single_thread_proxy.h (right):
> 
>
https://codereview.chromium.org/11565022/diff/1/cc/single_thread_proxy.h#newc...
> cc/single_thread_proxy.h:43: virtual void mainThreadHasStoppedFlinging()
> OVERRIDE { };
> nit: no trailing semicolon
> 
> https://codereview.chromium.org/11565022/diff/1/cc/thread_proxy.cc
> File cc/thread_proxy.cc (right):
> 
> https://codereview.chromium.org/11565022/diff/1/cc/thread_proxy.cc#newcode436
> cc/thread_proxy.cc:436: if (m_inputHandlerOnImplThread.get())
> nits:
> 
> - just "if (m_inputHandlerOnImplThread)" will do the right thing
> - this file is still WebKit style, so 4-space indents

[Yusuf, 2012-12-13 22:02:01]

WebKit side change https://bugs.webkit.org/show_bug.cgi?id=104947

[commit-bot: I haz the power, 2012-12-16 07:23:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusufo@chromium.org/11565022/11001

[commit-bot: I haz the power, 2012-12-16 07:41:35]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-16 20:12:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusufo@chromium.org/11565022/11001

[commit-bot: I haz the power, 2012-12-16 20:21:05]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-17 15:10:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusufo@chromium.org/11565022/11001

[commit-bot: I haz the power, 2012-12-17 18:23:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusufo@chromium.org/11565022/11001

[commit-bot: I haz the power, 2012-12-17 18:23:56]

Change committed as 173492