Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js

Index: chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
diff --git a/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js b/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
new file mode 100644
index 0000000000000000000000000000000000000000..b6b1fbd866ec87f0e57fd1b4dc74eca9cae026d0
--- /dev/null
+++ b/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
@@ -0,0 +1,211 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+GEN('#include "chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.h"');
+
+/**
+ * Test C++ fixture for Language Options WebUI testing.
+ * @constructor
+ * @extends {testing.Test}
+ */
+function MultilanguageOptionsWebUIBrowserTest() {}
+
+MultilanguageOptionsWebUIBrowserTest.prototype = {
+  __proto__: testing.Test.prototype,
+
+  /** @override */
+  browsePreload: 'chrome://settings-frame/languages',
+
+  /** @override */
+  typedefCppFixture: 'MultilanguageOptionsWebUIBrowserTest',
+
+  /** @override */
+  accessibilityIssuesAreErrors: true,
+
+  /** @return {Array<string>} The currently selected languages. */
+  getLanguages: function() {
+    return Object.keys(LanguageOptions.getInstance().spellCheckLanguages_);
+  },
+
+  /** @override */
+  setUp: function() {
+    testing.Test.prototype.setUp.call(this);
+
+    assertTrue(loadTimeData.getBoolean('enableMultilingualSpellChecker'));
+    assertFalse(cr.isMac);
+    expectTrue($('spellcheck-language-button').hidden);
+
+    // Make sure the only language currently selected is 'fr'.
+    var languageOptions = LanguageOptions.getInstance();
+    var languages = Object.keys(languageOptions.spellCheckLanguages_);

[Dan Beam, 2015/07/06 23:30:28]

use this.getLanguages()

[Julius, 2015/07/07 01:14:21]

Done.

+    expectEquals(1, languages.length);
+    expectEquals('fr', languages[0]);
+  },
+};
+
+// Test opening language options has correct location.
+TEST_F('MultilanguageOptionsWebUIBrowserTest', 'TestOpenLanguageOptions',
+       function() {
+  expectEquals('chrome://settings-frame/languages', document.location.href);
+});
+
+// Verify that the option to enable the spelling service is hidden when
+// multilingual spellchecking is enabled.
+TEST_F('MultilanguageOptionsWebUIBrowserTest', 'HideSpellingServiceCheckbox',
+       function() {
+  assertTrue(loadTimeData.getBoolean('enableMultilingualSpellChecker'));
+  expectTrue($('spelling-enabled-container').hidden);
+  testDone();
+});
+
+// Test that only certain languages can be selected and used for spellchecking.
+// prefs::kLanguagePreferredLanguages/prefs::kAcceptLanguages is set to
+// "fr,es,de,en" for the test.
+TEST_F('MultilanguageOptionsWebUIBrowserTest', 'ChangeSpellcheckLanguages',
+       function() {
+  var languages = this.getLanguages();

[Dan Beam, 2015/07/06 23:30:28]

you don't use this... you only reset it later...

[Julius, 2015/07/07 01:14:21]

I was thinking to declare variables at the start of the test. I'll move the
declaration down to where it's used.

+
+  // Make sure 'es' exists in the language list and is unchecked.
+  expectTrue($('language-options-list').selectLanguageByCode('es'));
+  LanguageOptions.updateSpellCheckLanguageControls('es');
+  expectFalse($('spellcheck-language-checkbox').checked, 'es');
+
+  // Click 'es' and ensure that its checkbox gets checked.
+  $('spellcheck-language-checkbox').click();
+  expectTrue($('spellcheck-language-checkbox').checked, 'es');
+
+  // Make sure 'fr' stays checked.
+  $('language-options-list').selectLanguageByCode('fr');
+  LanguageOptions.updateSpellCheckLanguageControls('fr');
+  expectTrue($('spellcheck-language-checkbox').checked);
+
+  // Make sure 'fr' and 'es' are the only two languages being spellchecked with.
+  languages = this.getLanguages();
+  expectEquals(2, languages.length);

[Dan Beam, 2015/07/06 23:30:28]

alternatively just call .getLanguages().length and .getLanguages()[0] if you
never want the result to be cached (I don't care if it's .1ms slower, it's test
code)

[Julius, 2015/07/07 01:14:21]

I think it's a bit more clear using languages instead of this.getLanguages()
every time.

+  expectEquals('fr', languages[0]);
+  expectEquals('es', languages[1]);
+
+  // Make sure 'fr' exists in the language list and is checked.
+  expectTrue($('language-options-list').selectLanguageByCode('fr'));
+  LanguageOptions.updateSpellCheckLanguageControls('fr');
+  expectTrue($('spellcheck-language-checkbox').checked);
+
+  // Click 'fr' and ensure that its checkbox gets unchecked.
+  $('spellcheck-language-checkbox').click();
+  expectFalse($('spellcheck-language-checkbox').checked);
+
+  // Make sure 'es' stays checked.
+  $('language-options-list').selectLanguageByCode('es');
+  LanguageOptions.updateSpellCheckLanguageControls('es');
+  expectTrue($('spellcheck-language-checkbox').checked);
+
+  // Make sure es' is the only language being spellchecked with.
+  languages = this.getLanguages();
+  expectEquals(1, languages.length);
+  expectEquals('es', languages[0]);
+});
+
+// Make sure 'am' cannot be selected as a language and 'fr' stays selected.
+TEST_F('MultilanguageOptionsWebUIBrowserTest', 'NotAcceptLanguage',
+       function() {
+  var languages = this.getLanguages();

[Dan Beam, 2015/07/06 23:30:28]

put this right before you actually use |languages|

[Julius, 2015/07/07 01:14:21]

Done.

+
+  // Try to select 'am' from the language list.
+  expectFalse($('language-options-list').selectLanguageByCode('am'));
+
+  // Make sure 'fr' is still the only thing selected.
+  $('language-options-list').selectLanguageByCode('fr');
+  expectTrue($('spellcheck-language-checkbox').checked);
+  expectEquals(1, languages.length);
+  expectEquals('fr', languages[0]);
+});
+
+// Make sure 'en' cannot be selected as a language and 'fr' stays selected.
+TEST_F('MultilanguageOptionsWebUIBrowserTest', 'UnusableLanguage',
+       function() {
+  var languages = this.getLanguages();

[Dan Beam, 2015/07/06 23:30:28]

lower and/or .getLanguages() every time

[Julius, 2015/07/07 01:14:21]

Done.

+
+  // Try to select 'en' from the language list.
+  expectTrue($('language-options-list').selectLanguageByCode('en'));
+  LanguageOptions.updateSpellCheckLanguageControls('en');
+  expectTrue($('spellcheck-language-checkbox-container').hidden);
+  expectFalse($('spellcheck-language-checkbox').checked);
+
+  // Make sure 'fr' is still the only thing selected.
+  expectEquals(1, languages.length);
+  expectEquals('fr', languages[0]);
+});
+
+function MultilanguagePreferenceWebUIBrowserTest() {}
+
+/**
+ * Test C++ fixture for Language Options WebUI testing.
+ * @constructor
+ * @extends {MultilanguageOptionsWebUIBrowserTest}
+ */
+MultilanguagePreferenceWebUIBrowserTest.prototype = {
+  __proto__: MultilanguageOptionsWebUIBrowserTest.prototype,
+
+  /** @override */
+  typedefCppFixture: 'MultilanguageOptionsWebUIBrowserTest',
+
+  /** @override */
+  testGenPreamble: function() {
+    GEN('SetBlankDictionariesPref();');
+  },
+
+  isAsync: true,
+
+  /** @override */
+  setUp: function() {
+    testing.Test.prototype.setUp.call(this);
+
+    assertTrue(loadTimeData.getBoolean('enableMultilingualSpellChecker'));
+    assertFalse(cr.isMac);
+    expectTrue($('spellcheck-language-button').hidden);
+
+    // Make sure we're starting with a blank preference.
+    var langs = Object.keys(LanguageOptions.getInstance().spellCheckLanguages_);

[Dan Beam, 2015/07/06 23:30:28]

...

[Julius, 2015/07/07 01:14:21]

Done.

+    var regPrefs = options.Preferences.getInstance().registeredPreferences_;
+    expectEquals(0, langs.length);
+    expectEquals(0, regPrefs['spellcheck.dictionaries'].orig.value.length);
+  },
+};
+
+// Make sure the case where no languages are selected is handled properly.
+TEST_F('MultilanguagePreferenceWebUIBrowserTest', 'BlankSpellcheckLanguges',
+       function() {
+  var languages = this.getLanguages();

[Dan Beam, 2015/07/06 23:30:28]

unused?

[Julius, 2015/07/07 01:14:21]

Moved it down into the event listener callback.

+  var registeredPrefs =
+      options.Preferences.getInstance().registeredPreferences_;
+
+  // Make sure 'fr' is not already checked.
+  expectTrue($('language-options-list').selectLanguageByCode('fr'));
+  LanguageOptions.updateSpellCheckLanguageControls('fr');
+  expectFalse($('spellcheck-language-checkbox').checked);
+
+  // Add a preference change event listener which ensures that the preference is
+  // updated correctly and that 'fr' is the only thing in the dictionary object.
+  options.Preferences.getInstance().addEventListener('spellcheck.dictionaries',
+      function() {
+    expectTrue($('spellcheck-language-checkbox').checked);
+
+    expectEquals(1,
+                 registeredPrefs['spellcheck.dictionaries'].orig.value.length);
+    expectEquals('fr',
+                 registeredPrefs['spellcheck.dictionaries'].orig.value[0]);
+
+    languages =
+        MultilanguagePreferenceWebUIBrowserTest.prototype.getLanguages();
+    expectEquals(1, languages.length);
+    expectEquals('fr', languages[0]);
+
+    expectTrue($('language-options-list').selectLanguageByCode('fr'));
+    testDone();
+  });
+
+  // Click 'fr' and trigger the previously registered event listener.
+  $('spellcheck-language-checkbox').click();
+
+});