Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1499)

Unified Diff: chrome/browser/ui/webui/options/language_options_handler_common.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replied to old comments and fixed small issues. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/language_options_handler_common.cc
diff --git a/chrome/browser/ui/webui/options/language_options_handler_common.cc b/chrome/browser/ui/webui/options/language_options_handler_common.cc
index 98a17872f1ff6f95a2c382e8becdb8c6c3b5808c..d955264b14f9e2c6a6aa5de4937769e2f379d9e6 100644
--- a/chrome/browser/ui/webui/options/language_options_handler_common.cc
+++ b/chrome/browser/ui/webui/options/language_options_handler_common.cc
@@ -132,6 +132,10 @@ void LanguageOptionsHandlerCommon::GetLocalizedValues(
localized_strings->SetBoolean("enableSpellingAutoCorrect",
enable_spelling_auto_correct);
+ localized_strings->SetBoolean(
+ "enableMultilingualSpellChecker",
+ chrome::spellcheck_common::IsMultilingualSpellcheckEnabled());
+
Profile* profile = Profile::FromWebUI(web_ui());
PrefService* prefs = profile->GetPrefs();
std::string default_target_language =
@@ -254,7 +258,6 @@ void LanguageOptionsHandlerCommon::SpellCheckLanguageChangeCallback(
const base::ListValue* args) {
const std::string language_code =
base::UTF16ToASCII(ExtractStringValue(args));
- CHECK(!language_code.empty());
please use gerrit instead 2015/07/06 23:28:15 Why remove this?
Julius 2015/07/07 01:14:21 Because now language_code can actually be empty if
const std::string action = base::StringPrintf(
"LanguageOptions_SpellCheckLanguageChange_%s", language_code.c_str());
content::RecordComputedAction(action);

Powered by Google App Engine
This is Rietveld 408576698