Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: chrome/browser/spellchecker/spellcheck_service.h

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL:
Patch Set: Replied to old comments and fixed small issues. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_service.h
diff --git a/chrome/browser/spellchecker/spellcheck_service.h b/chrome/browser/spellchecker/spellcheck_service.h
index 246d24a2275e859713a1c28f52ec9072df91969c..37f5badb4a30fe8fc2f6cc6942f6e73f2a108488 100644
--- a/chrome/browser/spellchecker/spellcheck_service.h
+++ b/chrome/browser/spellchecker/spellcheck_service.h
@@ -64,13 +64,13 @@ class SpellcheckService : public KeyedService,
base::WeakPtr<SpellcheckService> GetWeakPtr();
- // This function computes a vector of strings which are to be displayed in
- // the context menu over a text area for changing spell check languages. It
- // returns the index of the current spell check language in the vector.
+ // Computes |languages| to display in the context menu over a text area for
+ // changing spellcheck languages. Returns the number of languages that are
+ // enabled, which are always at the beginning of |languages|.
// TODO(port): this should take a vector of base::string16, but the
// implementation has some dependencies in l10n util that need porting first.
- static int GetSpellCheckLanguages(base::SupportsUserData* context,
- std::vector<std::string>* languages);
+ static size_t GetSpellCheckLanguages(base::SupportsUserData* context,
+ std::vector<std::string>* languages);
// Signals the event attached by AttachTestEvent() to report the specified
// event to browser tests. This function is called by this class and its
@@ -144,7 +144,7 @@ class SpellcheckService : public KeyedService,
// Reacts to a change in user preference on which language should be used for
please use gerrit instead 2015/07/06 23:28:15 s/language/languages
Julius 2015/07/07 01:14:21 Done.
// spellchecking.
- void OnSpellCheckDictionaryChanged();
+ void OnSpellCheckDictionariesChanged();
// Notification handler for changes to prefs::kSpellCheckUseSpellingService.
void OnUseSpellingServiceChanged();

Powered by Google App Engine
This is Rietveld 408576698