Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/spellchecker/spellcheck_service.cc

Index: chrome/browser/spellchecker/spellcheck_service.cc
diff --git a/chrome/browser/spellchecker/spellcheck_service.cc b/chrome/browser/spellchecker/spellcheck_service.cc
index 314b32405a47d2fef77e751a256bff3e4914ddf8..93ac12751e890ed7531b24399d0bcf1d1c37ffcf 100644
--- a/chrome/browser/spellchecker/spellcheck_service.cc
+++ b/chrome/browser/spellchecker/spellcheck_service.cc
@@ -8,6 +8,7 @@
 #include "base/prefs/pref_member.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_split.h"
+#include "base/supports_user_data.h"
 #include "base/synchronization/waitable_event.h"
 #include "chrome/browser/spellchecker/feedback_sender.h"
 #include "chrome/browser/spellchecker/spellcheck_factory.h"
@@ -43,10 +44,21 @@ SpellcheckService::SpellcheckService(content::BrowserContext* context)
   PrefService* prefs = user_prefs::UserPrefs::Get(context);
   pref_change_registrar_.Init(prefs);
 
+  std::string spellcheck_language;
+  if (chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()) {
+    std::vector<std::string> dictionary_languages;

[groby-ooo-7-16, 2015/06/24 22:12:23]

As said above, please use a list pref. Preferences have built-in support for
lists, we shouldn't hand-code our own formats on top of preferences if we don't
have to.

[Julius, 2015/07/06 22:38:53]

Done.

+    base::SplitString(prefs->GetString(prefs::kSpellCheckDictionaries), ',',
+                      &dictionary_languages);
+    if (!dictionary_languages.empty())
+      spellcheck_language = dictionary_languages.front();
+  } else {
+    spellcheck_language = prefs->GetString(prefs::kSpellCheckDictionary);
+  }
+
   std::string language_code;
   std::string country_code;
   chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(
-      prefs->GetString(prefs::kSpellCheckDictionary),
+      spellcheck_language,
       &language_code,
       &country_code);
   feedback_sender_.reset(new spellcheck::FeedbackSender(
@@ -56,14 +68,23 @@ SpellcheckService::SpellcheckService(content::BrowserContext* context)
       prefs::kEnableAutoSpellCorrect,
       base::Bind(&SpellcheckService::OnEnableAutoSpellCorrectChanged,
                  base::Unretained(this)));
-  pref_change_registrar_.Add(
-      prefs::kSpellCheckDictionary,
-      base::Bind(&SpellcheckService::OnSpellCheckDictionaryChanged,
-                 base::Unretained(this)));
- pref_change_registrar_.Add(
-     prefs::kSpellCheckUseSpellingService,
-     base::Bind(&SpellcheckService::OnUseSpellingServiceChanged,
-                base::Unretained(this)));
+
+  if (chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()) {
+    pref_change_registrar_.Add(
+        prefs::kSpellCheckDictionaries,
+        base::Bind(&SpellcheckService::OnSpellCheckDictionaryChanged,
+                   base::Unretained(this)));
+  } else {
+    pref_change_registrar_.Add(
+        prefs::kSpellCheckDictionary,
+        base::Bind(&SpellcheckService::OnSpellCheckDictionaryChanged,
+                   base::Unretained(this)));
+    pref_change_registrar_.Add(
+        prefs::kSpellCheckUseSpellingService,
+        base::Bind(&SpellcheckService::OnUseSpellingServiceChanged,
+                   base::Unretained(this)));
+  }
+
   pref_change_registrar_.Add(
       prefs::kEnableContinuousSpellcheck,
       base::Bind(&SpellcheckService::InitForAllRenderers,
@@ -90,46 +111,18 @@ base::WeakPtr<SpellcheckService> SpellcheckService::GetWeakPtr() {
 }
 
 // static
-int SpellcheckService::GetSpellCheckLanguages(
-    content::BrowserContext* context,
+size_t SpellcheckService::GetSpellCheckLanguages(
+    base::SupportsUserData* context,

[groby-ooo-7-16, 2015/06/24 22:12:23]

Why move this to SupportsUserData?

[Julius, 2015/07/06 22:38:53]

This makes it easier to test that GetSpellCheckLanguages is working properly.

     std::vector<std::string>* languages) {
   PrefService* prefs = user_prefs::UserPrefs::Get(context);
   StringPrefMember accept_languages_pref;
-  StringPrefMember dictionary_language_pref;
   accept_languages_pref.Init(prefs::kAcceptLanguages, prefs);
-  dictionary_language_pref.Init(prefs::kSpellCheckDictionary, prefs);
-  std::string dictionary_language = dictionary_language_pref.GetValue();
 
-  // Now scan through the list of accept languages, and find possible mappings
-  // from this list to the existing list of spell check languages.
   std::vector<std::string> accept_languages;
-
-#if defined(OS_MACOSX)
-  if (spellcheck_mac::SpellCheckerAvailable())

[groby-ooo-7-16, 2015/06/24 22:12:23]

Why are we getting rid of the OSX path?

[Julius, 2015/07/06 22:38:53]

This function never actually gets called on OSX.

-    spellcheck_mac::GetAvailableLanguages(&accept_languages);
-  else
-    base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
-#else
   base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
-#endif  // !OS_MACOSX
 
-  GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, dictionary_language, languages);
-
-  for (size_t i = 0; i < languages->size(); ++i) {
-    if ((*languages)[i] == dictionary_language)
-      return i;
-  }
-  return -1;
-}
-
-// static
-void SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
-    const std::vector<std::string>& accept_languages,
-    const std::string& dictionary_language,
-    std::vector<std::string>* languages) {
-  // The current dictionary language should be there.
-  languages->push_back(dictionary_language);
+  *languages = chrome::spellcheck_common::GetDictionaryLanguagesPref(prefs);
+  size_t enabled_spellcheck_languages = languages->size();
 
   for (std::vector<std::string>::const_iterator i = accept_languages.begin();
        i != accept_languages.end(); ++i) {
@@ -137,10 +130,12 @@ void SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
         chrome::spellcheck_common::GetCorrespondingSpellCheckLanguage(*i);
     if (!language.empty() &&
         std::find(languages->begin(), languages->end(), language) ==
-        languages->end()) {
+            languages->end()) {
       languages->push_back(language);
     }
   }
+
+  return enabled_spellcheck_languages;
 }
 
 // static
@@ -288,11 +283,19 @@ void SpellcheckService::OnEnableAutoSpellCorrectChanged() {
 void SpellcheckService::OnSpellCheckDictionaryChanged() {
   if (hunspell_dictionary_.get())
     hunspell_dictionary_->RemoveObserver(this);
-  PrefService* prefs = user_prefs::UserPrefs::Get(context_);
-  DCHECK(prefs);
 
-  std::string dictionary =
-      prefs->GetString(prefs::kSpellCheckDictionary);
+  std::string dictionary;
+  if (chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()) {

[groby-ooo-7-16, 2015/06/24 22:12:23]

If we migrated prefs, that would turn into a single code path...

[Julius, 2015/07/06 22:38:53]

Acknowledged.

+    std::vector<std::string> languages;
+    size_t dictionary_languages = GetSpellCheckLanguages(context_, &languages);
+    if (dictionary_languages > 0) {
+      DCHECK(!languages.empty());
+      dictionary = languages.front();
+    }
+  } else {
+    dictionary = user_prefs::UserPrefs::Get(context_)
+                     ->GetString(prefs::kSpellCheckDictionary);
+  }
   hunspell_dictionary_.reset(new SpellcheckHunspellDictionary(
       dictionary, context_->GetRequestContext(), this));
   hunspell_dictionary_->AddObserver(this);