chrome/browser/resources/options/browser_options.html - Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/browser_options.html

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed nits and rebased. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_menu_observer.cc ('k') | chrome/browser/resources/options/language_options.html » ('j') | chrome/browser/resources/options/language_options.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/browser_options.html

diff --git a/chrome/browser/resources/options/browser_options.html b/chrome/browser/resources/options/browser_options.html

index 47ddcc92e92ccf89102dacde9dac00d038f66b21..a235bf9f576afcbb2f37cb6fedac0c33309ffca1 100644

--- a/chrome/browser/resources/options/browser_options.html

+++ b/chrome/browser/resources/options/browser_options.html

@@ -415,8 +415,8 @@

</span>

</label>

</div>

-<if expr="_google_chrome">

- <div class="checkbox controlled-setting-with-label">

+ <div id="spelling-enabled-container"

+ class="checkbox controlled-setting-with-label">

Dan Beam 2015/06/25 02:25:59 4 \s indent

Julius 2015/07/06 22:38:52 Done.

<label>

<input id="spelling-enabled-control" type="checkbox"

metric="Options_SpellingServiceCheckbox"

@@ -431,6 +431,7 @@

</div>

<div id="metrics-reporting-setting"

class="checkbox controlled-setting-with-label">

+<if expr="_google_chrome">

Dan Beam 2015/06/25 02:25:59 this should probably be above <div id="metrics-rep

Dan Beam 2015/06/25 02:25:59 please either update the CL description to say "sp

Julius 2015/07/06 22:38:52 Did it in a new CL.

Julius 2015/07/06 22:38:52 Done.

<label>

<input id="metrics-reporting-enabled"