chrome/browser/about_flags.cc - Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverted from using any #if defines to exclude Mac compiles. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h » ('j') | chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 1f94e3b872f6d46208238d7c29648e60c7e7fe97..a73f4c70b46bfbe07a3c0d0e246dc98027df02ca 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -1999,9 +1999,19 @@ const Experiment kExperiments[] = {

kOsAll,

SINGLE_VALUE_TYPE(switches::kEnableWebVR)},

#endif

- // NOTE: Adding new command-line switches requires adding corresponding

- // entries to enum "LoginCustomFlags" in histograms.xml. See note in

- // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

+#if defined(ENABLE_SPELLCHECK) && \

+ (defined(OS_LINUX) || defined(OS_WIN) || defined(OS_CHROMEOS))

+ {

+ "enable-multilingual-spellchecker",

please use gerrit instead 2015/06/23 21:56:01 previous entry is clang-formatted. Maybe clang-for

Julius 2015/06/24 21:17:59 It reformats the whole file but I've reformatted m

+ IDS_FLAGS_ENABLE_MULTILINGUAL_SPELLCHECKER_NAME,

+ IDS_FLAGS_ENABLE_MULTILINGUAL_SPELLCHECKER_DESCRIPTION,

+ kOsWin | kOsLinux | kOsCrOS,

+ SINGLE_VALUE_TYPE(switches::kEnableMultilingualSpellChecker)

+ },

+#endif

+ // NOTE: Adding new command-line switches requires adding corresponding

please use gerrit instead 2015/06/23 21:56:00 I think the original comment had 4 spaces. Let's n

Julius 2015/06/24 21:17:59 Done.

+ // entries to enum "LoginCustomFlags" in histograms.xml. See note in

+ // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

};

const Experiment* experiments = kExperiments;