chrome/browser/renderer_context_menu/spelling_menu_observer.cc - Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/spelling_menu_observer.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disabled service client when multilingual spellcheck is enabled. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc ('k') | chrome/browser/resources/options/language_options.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/spelling_menu_observer.cc

diff --git a/chrome/browser/renderer_context_menu/spelling_menu_observer.cc b/chrome/browser/renderer_context_menu/spelling_menu_observer.cc

index dca75263598982f9a1d834e20bf82a6b57245b00..166dc2da83b77fb27f7b736a68a7d0c2b2e14c78 100644

--- a/chrome/browser/renderer_context_menu/spelling_menu_observer.cc

+++ b/chrome/browser/renderer_context_menu/spelling_menu_observer.cc

@@ -22,6 +22,7 @@

#include "chrome/browser/ui/confirm_bubble.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

+#include "chrome/common/spellcheck_common.h"

#include "chrome/common/spellcheck_result.h"

#include "chrome/grit/generated_resources.h"

#include "content/public/browser/render_view_host.h"

@@ -231,7 +232,8 @@ bool SpellingMenuObserver::IsCommandIdEnabled(int command_id) {

case IDC_CONTENT_CONTEXT_SPELLING_TOGGLE:

return integrate_spelling_service_.IsUserModifiable() &&

- !profile->IsOffTheRecord();

+ !profile->IsOffTheRecord() &&

+ !chrome::spellcheck_common::IsMultilingualSpellcheckEnabled();

case IDC_CONTENT_CONTEXT_AUTOCORRECT_SPELLING_TOGGLE:

return integrate_spelling_service_.IsUserModifiable() &&