Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js

Index: chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
diff --git a/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js b/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
new file mode 100644
index 0000000000000000000000000000000000000000..c198c5a5b62cd8ec00cf8d8ea9d2ee84de27757e
--- /dev/null
+++ b/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
@@ -0,0 +1,100 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+GEN('#include "chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.h"');
+
+/**
+ * Test C++ fixture for Language Options WebUI testing.
+ * @constructor
+ * @extends {testing.Test}
+ */
+function MultilanguageOptionsWebUIBrowserTest() {}
+
+MultilanguageOptionsWebUIBrowserTest.prototype = {
+  __proto__: testing.Test.prototype,
+
+  /**
+   * Browse to the language options page & call our preLoad().
+   */
+  browsePreload: 'chrome://settings-frame/languages/',
+
+  /** @override */
+  typedefCppFixture: 'MultilanguageOptionsWebUIBrowserTest',
+
+  /** @override */
+  runAccessibilityChecks: true,

[Dan Beam, 2015/06/17 23:42:01]

^ unnecessary (true is already the default)

[Julius, 2015/06/24 21:17:58]

Deleted.

+
+  /** @override */
+  accessibilityIssuesAreErrors: true,
+};
+
+// Test opening language options has correct location.
+TEST_F('MultilanguageOptionsWebUIBrowserTest',
+       'testOpenLanguageOptions',

[Dan Beam, 2015/06/17 23:42:01]

TEST_F('MultilanguageOptionsWebUIBrowserTest', 'testOpenLanguageOptions',
       function() {

[Julius, 2015/06/24 21:17:58]

Done.

+       function() {
+  expectEquals('chrome://settings-frame/languages/', document.location.href);
+});
+
+// Test that only certain languages can be selected and used for spellchecking.
+// prefs::kLanguagePreferredLanguages/prefs::kAcceptLanguages is set to
+// "fr,es,de" for the test.
+TEST_F('MultilanguageOptionsWebUIBrowserTest',
+       'languageOptions',
+       function() {

[Dan Beam, 2015/06/17 23:42:01]

TEST_F('MultilanguageOptionsWebUIBrowserTest', 'languageOptions',
       function() {

[Julius, 2015/06/24 21:17:58]

Done.

+  expectTrue(loadTimeData.getBoolean('enableMultilingualSpellChecker'));

[Dan Beam, 2015/06/17 23:42:01]

assertTrue(loadTimeData.getBoolean('enableMultilingualSpellChecker'));

[Julius, 2015/06/24 21:17:58]

Done.

+  assert(!cr.isMac);

[Dan Beam, 2015/06/17 23:42:01]

assertFalse(cr.isMac);

[Julius, 2015/06/24 21:17:58]

Done.

+
+  expectTrue($('spellcheck-language-button').hidden);
+  var langOps = LanguageOptions.getInstance();

[Dan Beam, 2015/06/17 23:42:01]

langOpts

[Julius, 2015/06/24 21:17:58]

Done.

+
+  // Make sure the only language currently selected is 'fr'.

[Dan Beam, 2015/06/17 23:42:01]

that's not what this code is doing

var langs = Object.keys(langOps.spellCheckLanguages_);
expectEquals(1, langs.length);
expectEquals('fr', langs[0]);

[Julius, 2015/06/24 21:17:58]

Done.

+  expectTrue(langOps.spellCheckLanguages_.hasOwnProperty('fr'));
+  expectTrue($('language-options-list').selectLanguageByCode('fr'));
+  expectTrue($('spellcheck-language-checkbox').checked);
+
+  // Click 'es' and ensure that its checkbox gets checked, 'fr' stays,
+  // checked, and those are the only languages being used for spellchecking.
+  expectTrue($('language-options-list').selectLanguageByCode('es'));
+  LanguageOptions.updateSpellCheckLanguageControls('es');
+  expectFalse($('spellcheck-language-checkbox').checked, 'es');
+  $('spellcheck-language-checkbox').click();
+  expectTrue(langOps.spellCheckLanguages_.hasOwnProperty('es'));
+  expectTrue($('spellcheck-language-checkbox').checked, 'es');
+  $('language-options-list').selectLanguageByCode('fr');
+  LanguageOptions.updateSpellCheckLanguageControls('fr');
+  expectTrue($('spellcheck-language-checkbox').checked);
+  expectTrue(langOps.spellCheckLanguages_.hasOwnProperty('fr'));
+  expectTrue(langOps.spellCheckLanguages_.hasOwnProperty('es'));
+
+  // Check that 'am' cannot be selected as a language and make sure the other
+  // languages stay selected.
+  expectFalse($('language-options-list').selectLanguageByCode('am'));
+  $('language-options-list').selectLanguageByCode('fr');
+  expectTrue($('spellcheck-language-checkbox').checked);
+  $('language-options-list').selectLanguageByCode('es');
+  expectTrue($('spellcheck-language-checkbox').checked, 'es');
+  expectTrue(langOps.spellCheckLanguages_.hasOwnProperty('fr'));
+  expectTrue(langOps.spellCheckLanguages_.hasOwnProperty('es'));
+  expectFalse(langOps.spellCheckLanguages_.hasOwnProperty('am'));
+
+  // Click 'fr' and ensure that its checkbox gets unchecked, 'es' stays,
+  // checked, and that is the only language being used for spellchecking.
+  $('language-options-list').selectLanguageByCode('fr');
+  LanguageOptions.updateSpellCheckLanguageControls('fr');
+  expectTrue($('spellcheck-language-checkbox').checked);
+  $('spellcheck-language-checkbox').click();
+  expectFalse(langOps.spellCheckLanguages_.hasOwnProperty('fr'));
+  expectFalse($('spellcheck-language-checkbox').checked);
+  $('language-options-list').selectLanguageByCode('es');
+  LanguageOptions.updateSpellCheckLanguageControls('es');
+  expectTrue($('spellcheck-language-checkbox').checked, 'es');
+  expectTrue(langOps.spellCheckLanguages_.hasOwnProperty('es'));
+
+  // Make sure 'en' cannot be used as a spellchecking language.
+  $('language-options-list').selectLanguageByCode('en');
+  LanguageOptions.updateSpellCheckLanguageControls('en');
+  expectTrue($('spellcheck-language-checkbox-container').hidden);
+  expectFalse($('spellcheck-language-checkbox').checked);
+  expectFalse(langOps.spellCheckLanguages_.hasOwnProperty('en'));

[Dan Beam, 2015/06/17 23:42:01]

split these paragraphs into multiple tests with a comment setUp method

[Julius, 2015/06/24 21:17:58]

Done.

+});