 Chromium Code Reviews
 Chromium Code Reviews Issue 1156473007:
  Enables the user to select multiple languages for spellchecking (UI)  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1156473007:
  Enables the user to select multiple languages for spellchecking (UI)  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/spellchecker/spellcheck_factory.cc | 
| diff --git a/chrome/browser/spellchecker/spellcheck_factory.cc b/chrome/browser/spellchecker/spellcheck_factory.cc | 
| index edbed4055410f4b5c9027f3023dea245aa2fd68d..bff0faae03eb24aa02ec78599d4e7c5e8c88540f 100644 | 
| --- a/chrome/browser/spellchecker/spellcheck_factory.cc | 
| +++ b/chrome/browser/spellchecker/spellcheck_factory.cc | 
| @@ -8,6 +8,7 @@ | 
| #include "chrome/browser/profiles/incognito_helpers.h" | 
| #include "chrome/browser/spellchecker/spellcheck_service.h" | 
| #include "chrome/common/pref_names.h" | 
| +#include "chrome/common/spellcheck_common.h" | 
| #include "chrome/grit/locale_settings.h" | 
| #include "components/keyed_service/content/browser_context_dependency_manager.h" | 
| #include "components/pref_registry/pref_registry_syncable.h" | 
| @@ -69,9 +70,17 @@ KeyedService* SpellcheckServiceFactory::BuildServiceInstanceFor( | 
| void SpellcheckServiceFactory::RegisterProfilePrefs( | 
| user_prefs::PrefRegistrySyncable* user_prefs) { | 
| // TODO(estade): IDS_SPELLCHECK_DICTIONARY should be an ASCII string. | 
| + | 
| + if (chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()) { | 
| + user_prefs->RegisterStringPref( | 
| 
groby-ooo-7-16
2015/06/18 00:44:29
Why do we need a second stringpref?
 
Julius
2015/06/24 21:17:57
This has been fixed. We now only set one or the ot
 | 
| + prefs::kSpellCheckDictionaries, | 
| + l10n_util::GetStringUTF8(IDS_SPELLCHECK_DICTIONARY)); | 
| + } | 
| + | 
| user_prefs->RegisterStringPref( | 
| prefs::kSpellCheckDictionary, | 
| l10n_util::GetStringUTF8(IDS_SPELLCHECK_DICTIONARY)); | 
| + | 
| 
groby-ooo-7-16
2015/06/18 00:44:29
Since there wasn't a newline before, let's not add
 
Julius
2015/06/24 21:17:57
Done.
 | 
| user_prefs->RegisterBooleanPref(prefs::kSpellCheckUseSpellingService, false); | 
| user_prefs->RegisterBooleanPref( | 
| prefs::kEnableContinuousSpellcheck, |