chrome/browser/resources/options/language_options.html - Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI)

Unified Diff: chrome/browser/resources/options/language_options.html

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed a misleading comment. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc ('K') | « chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc ('k') | chrome/browser/resources/options/language_options.js » ('j') | chrome/browser/resources/options/language_options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/language_options.html

diff --git a/chrome/browser/resources/options/language_options.html b/chrome/browser/resources/options/language_options.html

index eebd29d375665afdeb1949dcc5552a1059cf7867..e076a8f842bc02d3abb3d9156c62e8b52101c08b 100644

--- a/chrome/browser/resources/options/language_options.html

+++ b/chrome/browser/resources/options/language_options.html

@@ -41,10 +41,18 @@

dictionary pane. -->

- <button id="language-options-spell-check-language-button"

+ <div class="checkbox"

+ id="spellcheck-language-checkbox-container">

Dan Beam 2015/06/17 23:42:00 unwrap, i.e. <div class="checkbox" id="spellche

Julius 2015/06/24 21:17:57 Done.

+ <label>

+ <input type="checkbox"

+ id="spellcheck-language-checkbox">

Dan Beam 2015/06/17 23:42:00 also unwrap this

Julius 2015/06/24 21:17:57 Done.

+ <span i18n-content="useThisForSpellChecking"></span>

+ </label>

+ </div>

+ <button id="spellcheck-language-button"

i18n-content="useThisForSpellChecking">

</button>

- <span id="language-options-spell-check-language-message" hidden>

+ <span id="spellcheck-language-message" hidden>

</span>

<span id="language-options-dictionary-downloading-message"

i18n-content="downloadingDictionary" hidden>

@@ -111,9 +119,9 @@

i18n-content="languageDictionaryOverlayTitle"></a>

</if>

- <div id="spell-check-option" class="checkbox">

+ <div id="spellcheck-option" class="checkbox">

Dan Beam 2015/06/17 23:42:00 unused ID

Julius 2015/06/24 21:17:57 Removed id attribute.

<label>

- <input id="enable-spell-check" pref="browser.enable_spellchecking"

+ <input id="enable-spellcheck" pref="browser.enable_spellchecking"

metric="Options_SpellCheck" type="checkbox">

</label>