chrome/browser/resources/options/language_options.html - Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/language_options.html

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed previous comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc ('k') | chrome/browser/resources/options/language_options.js » ('j') | chrome/browser/resources/options/language_options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/language_options.html

diff --git a/chrome/browser/resources/options/language_options.html b/chrome/browser/resources/options/language_options.html

index eebd29d375665afdeb1949dcc5552a1059cf7867..c201d8294ee497dd273f07d458dd1d9c7de9580b 100644

--- a/chrome/browser/resources/options/language_options.html

+++ b/chrome/browser/resources/options/language_options.html

@@ -41,10 +41,18 @@

dictionary pane. -->

- <button id="language-options-spell-check-language-button"

+ <div class="checkbox"

+ id="language-options-spellcheck-language-checkbox-div">

Dan Beam 2015/06/09 17:57:47 Don't put tag names in IDs

Julius 2015/06/15 22:47:34 Changed to "spellcheck-language-checkbox-container

+ <label>

+ <input type="checkbox"

+ id="language-options-spellcheck-language-checkbox">

Dan Beam 2015/06/09 17:57:47 Is there another spellcheck language this would be

Julius 2015/06/15 22:47:34 Nope. Done.

+ <span i18n-content="useThisForSpellChecking"></span>

+ </label>

+ </div>

+ <button id="language-options-spellcheck-language-button"

i18n-content="useThisForSpellChecking">

</button>

- <span id="language-options-spell-check-language-message" hidden>

+ <span id="language-options-spellcheck-language-message" hidden>

</span>

<span id="language-options-dictionary-downloading-message"

i18n-content="downloadingDictionary" hidden>

@@ -111,9 +119,9 @@

i18n-content="languageDictionaryOverlayTitle"></a>

</if>

- <div id="spell-check-option" class="checkbox">

+ <div id="spellcheck-option" class="checkbox">

<label>

- <input id="enable-spell-check" pref="browser.enable_spellchecking"

+ <input id="enable-spellcheck" pref="browser.enable_spellchecking"

metric="Options_SpellCheck" type="checkbox">

</label>