Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/common/spellcheck_common.h

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments, clarified code. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/spellcheck_common.h
diff --git a/chrome/common/spellcheck_common.h b/chrome/common/spellcheck_common.h
index cbdaf7bf08906ff3c5545f2dc84d9c773d37027f..075b35bbece9cd814c63917dd78e764fa6fe9972 100644
--- a/chrome/common/spellcheck_common.h
+++ b/chrome/common/spellcheck_common.h
@@ -12,6 +12,8 @@ namespace base {
class FilePath;
}
+class PrefService;
+
namespace chrome {
namespace spellcheck_common {
@@ -39,6 +41,9 @@ static const size_t MAX_SYNCABLE_DICTIONARY_WORDS = 1300;
// dictionary.
static const size_t MAX_CUSTOM_DICTIONARY_WORD_BYTES = 99;
+// Character that separates language codes saved in preferences.
+static const char kDictionaryLanguagesSeparator = ',';
+
base::FilePath GetVersionedFileName(const std::string& input_language,
const base::FilePath& dict_dir);
@@ -55,6 +60,13 @@ void GetISOLanguageCountryCodeFromLocale(const std::string& locale,
std::string* language_code,
std::string* country_code);
+// Reads the spellcheck.dictionary or spellcheck.dictionaries preference
please use gerrit instead 2015/06/05 17:50:06 No need to specify so much implementation details,
Julius 2015/06/05 21:38:33 Done.
+// (depending on whether the enable-multilingual-spellchecker flag is set), and
+// returns the language codes.
+std::vector<std::string> GetDictionaryLanguagesPref(PrefService* prefs);
+
+// Checks if the command-line switch enable-multilingual-spellchecker is set.
please use gerrit instead 2015/06/05 17:50:06 This comment will soon grow stale, because command
Julius 2015/06/05 21:38:33 Done.
+bool MultilingualSpellcheckIsEnabled();
please use gerrit instead 2015/06/05 17:50:06 Newline after.
Julius 2015/06/05 21:38:33 Done.
} // namespace spellcheck_common
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698