chrome/browser/ui/webui/options/language_options_handler_common.cc - Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/language_options_handler_common.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed nits and presubmit warnings. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js ('k') | chrome/browser/ui/webui/options/multilanguage_options_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/language_options_handler_common.cc

diff --git a/chrome/browser/ui/webui/options/language_options_handler_common.cc b/chrome/browser/ui/webui/options/language_options_handler_common.cc

index 98a17872f1ff6f95a2c382e8becdb8c6c3b5808c..d955264b14f9e2c6a6aa5de4937769e2f379d9e6 100644

--- a/chrome/browser/ui/webui/options/language_options_handler_common.cc

+++ b/chrome/browser/ui/webui/options/language_options_handler_common.cc

@@ -132,6 +132,10 @@ void LanguageOptionsHandlerCommon::GetLocalizedValues(

localized_strings->SetBoolean("enableSpellingAutoCorrect",

enable_spelling_auto_correct);

+ localized_strings->SetBoolean(

+ "enableMultilingualSpellChecker",

+ chrome::spellcheck_common::IsMultilingualSpellcheckEnabled());

Profile* profile = Profile::FromWebUI(web_ui());

PrefService* prefs = profile->GetPrefs();

std::string default_target_language =

@@ -254,7 +258,6 @@ void LanguageOptionsHandlerCommon::SpellCheckLanguageChangeCallback(

const base::ListValue* args) {

const std::string language_code =

base::UTF16ToASCII(ExtractStringValue(args));

- CHECK(!language_code.empty());

const std::string action = base::StringPrintf(

"LanguageOptions_SpellCheckLanguageChange_%s", language_code.c_str());

content::RecordComputedAction(action);