Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js

Index: chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
diff --git a/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js b/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
new file mode 100644
index 0000000000000000000000000000000000000000..7e66dde762bdb635cf2fe111dbe7599912d44f1b
--- /dev/null
+++ b/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
@@ -0,0 +1,190 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+GEN('#include "chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.h"');
+
+/**
+ * Test C++ fixture for Language Options WebUI testing.
+ * @constructor
+ * @extends {testing.Test}
+ */
+function MultilanguageOptionsWebUIBrowserTest() {}
+
+MultilanguageOptionsWebUIBrowserTest.prototype = {
+  __proto__: testing.Test.prototype,
+
+  /** @override */
+  browsePreload: 'chrome://settings-frame/languages',
+
+  /** @override */
+  typedefCppFixture: 'MultilanguageOptionsWebUIBrowserTest',

[Dan Beam, 2015/07/08 23:41:36]

the C++ and JS class should not be the same name

[Julius, 2015/07/09 03:54:51]

Done.

+
+  /** @override */
+  accessibilityIssuesAreErrors: true,
+
+  /** @param {string} Sorted, expected currently selected languages. */
+  expectCurrentlySelected: function(expected) {
+    var languages = LanguageOptions.getInstance().spellCheckLanguages_;
+    expectEquals(expected, Object.keys(languages).sort().join());
+  },
+
+  /** @override */
+  setUp: function() {
+    testing.Test.prototype.setUp.call(this);
+
+    assertTrue(loadTimeData.getBoolean('enableMultilingualSpellChecker'));
+    assertFalse(cr.isMac);
+    expectTrue($('spellcheck-language-button').hidden);
+
+    // Make sure the only language currently selected is 'fr'.
+    this.expectCurrentlySelected('fr');
+  },
+};
+
+// Test opening language options has correct location.
+TEST_F('MultilanguageOptionsWebUIBrowserTest', 'TestOpenLanguageOptions',
+       function() {
+  expectEquals('chrome://settings-frame/languages', document.location.href);
+});
+
+// Verify that the option to enable the spelling service is hidden when
+// multilingual spellchecking is enabled.
+TEST_F('MultilanguageOptionsWebUIBrowserTest', 'HideSpellingServiceCheckbox',
+       function() {
+  assertTrue(loadTimeData.getBoolean('enableMultilingualSpellChecker'));
+  expectTrue($('spelling-enabled-container').hidden);
+  testDone();
+});
+
+// Test that only certain languages can be selected and used for spellchecking.
+// prefs::kLanguagePreferredLanguages/prefs::kAcceptLanguages is set to
+// "fr,es,de,en" for the test.
+TEST_F('MultilanguageOptionsWebUIBrowserTest', 'ChangeSpellcheckLanguages',
+       function() {
+  // Make sure 'es' exists in the language list and is unchecked.
+  expectTrue($('language-options-list').selectLanguageByCode('es'));
+  LanguageOptions.updateSpellCheckLanguageControls('es');
+  expectFalse($('spellcheck-language-checkbox').checked, 'es');
+
+  // Click 'es' and ensure that its checkbox gets checked.
+  $('spellcheck-language-checkbox').click();
+  expectTrue($('spellcheck-language-checkbox').checked, 'es');
+
+  // Make sure 'fr' stays checked.
+  $('language-options-list').selectLanguageByCode('fr');
+  LanguageOptions.updateSpellCheckLanguageControls('fr');
+  expectTrue($('spellcheck-language-checkbox').checked);
+
+  // Make sure 'fr' and 'es' are the only two languages being spellchecked with.

[Dan Beam, 2015/07/08 23:41:37]

don't think these comments are necessary any longer... the code basically spells
out the same thing

[Julius, 2015/07/09 03:54:51]

Done, and I tried to consolidate and trim other unneeded comments elsewhere.

+  this.expectCurrentlySelected('es,fr');
+
+  // Make sure 'fr' exists in the language list and is checked.
+  expectTrue($('language-options-list').selectLanguageByCode('fr'));
+  LanguageOptions.updateSpellCheckLanguageControls('fr');
+  expectTrue($('spellcheck-language-checkbox').checked);
+
+  // Click 'fr' and ensure that its checkbox gets unchecked.
+  $('spellcheck-language-checkbox').click();
+  expectFalse($('spellcheck-language-checkbox').checked);
+
+  // Make sure 'es' stays checked.
+  $('language-options-list').selectLanguageByCode('es');
+  LanguageOptions.updateSpellCheckLanguageControls('es');
+  expectTrue($('spellcheck-language-checkbox').checked);
+
+  // Make sure 'es' is the only language being spellchecked with.
+  this.expectCurrentlySelected('es');
+});
+
+// Make sure 'am' cannot be selected as a language and 'fr' stays selected.
+TEST_F('MultilanguageOptionsWebUIBrowserTest', 'NotAcceptLanguage',
+       function() {
+  // Try to select 'am' from the language list.
+  expectFalse($('language-options-list').selectLanguageByCode('am'));
+
+  // Make sure 'fr' is still the only thing selected.
+  $('language-options-list').selectLanguageByCode('fr');
+  expectTrue($('spellcheck-language-checkbox').checked);
+  this.expectCurrentlySelected('fr');
+});
+
+// Make sure 'en' cannot be selected as a language and 'fr' stays selected.
+TEST_F('MultilanguageOptionsWebUIBrowserTest', 'UnusableLanguage',
+       function() {
+  // Try to select 'en' from the language list.
+  expectTrue($('language-options-list').selectLanguageByCode('en'));
+  LanguageOptions.updateSpellCheckLanguageControls('en');
+  expectTrue($('spellcheck-language-checkbox-container').hidden);
+  expectFalse($('spellcheck-language-checkbox').checked);
+
+  // Make sure 'fr' is still the only thing selected.
+  this.expectCurrentlySelected('fr');
+});
+
+function MultilanguagePreferenceWebUIBrowserTest() {}
+
+/**
+ * Test C++ fixture for Language Options WebUI testing.
+ * @constructor
+ * @extends {MultilanguageOptionsWebUIBrowserTest}
+ */
+MultilanguagePreferenceWebUIBrowserTest.prototype = {
+  __proto__: MultilanguageOptionsWebUIBrowserTest.prototype,
+
+  /** @override */
+  typedefCppFixture: 'MultilanguageOptionsWebUIBrowserTest',
+
+  /** @override */
+  testGenPreamble: function() {
+    GEN('SetBlankDictionariesPref();');
+  },
+
+  isAsync: true,
+
+  /** @override */
+  setUp: function() {
+    testing.Test.prototype.setUp.call(this);
+
+    assertTrue(loadTimeData.getBoolean('enableMultilingualSpellChecker'));
+    assertFalse(cr.isMac);
+    expectTrue($('spellcheck-language-button').hidden);
+
+    // Make sure we're starting with a blank preference.
+    this.expectCurrentlySelected('');
+    var registeredPrefs =
+        options.Preferences.getInstance().registeredPreferences_;
+    expectEquals(0,
+        registeredPrefs['spellcheck.dictionaries'].orig.value.length);

[Dan Beam, 2015/07/08 23:41:36]

combine this and the code at L177

[Julius, 2015/07/09 03:54:52]

Done.

+  },
+};
+
+// Make sure the case where no languages are selected is handled properly.
+TEST_F('MultilanguagePreferenceWebUIBrowserTest', 'BlankSpellcheckLanguges',
+       function() {
+  // Make sure 'fr' is not already checked.
+  expectTrue($('language-options-list').selectLanguageByCode('fr'));
+  LanguageOptions.updateSpellCheckLanguageControls('fr');
+  expectFalse($('spellcheck-language-checkbox').checked);
+
+  // Add a preference change event listener which ensures that the preference is
+  // updated correctly and that 'fr' is the only thing in the dictionary object.
+  options.Preferences.getInstance().addEventListener('spellcheck.dictionaries',

[Dan Beam, 2015/07/08 23:41:36]

var prefs = options.Preferences.getInstance();
prefs.getInstance().addEventListener('spellcheck.dictionaries',

[Julius, 2015/07/09 03:54:52]

Done. Even though this is the only places prefs is used now, I think it looks a
bit cleaner like this.

+      function() {
+    expectTrue($('spellcheck-language-checkbox').checked);
+
+    var registeredPrefs =
+        options.Preferences.getInstance().registeredPreferences_;
+    expectEquals(1,
+                 registeredPrefs['spellcheck.dictionaries'].orig.value.length);

[Dan Beam, 2015/07/08 23:41:37]

var registerPrefs = prefs.registeredPreferences_;

[Julius, 2015/07/09 03:54:52]

Done.

+    expectEquals('fr',
+                 registeredPrefs['spellcheck.dictionaries'].orig.value[0]);
+    MultilanguagePreferenceWebUIBrowserTest.prototype.expectCurrentlySelected(
+        'fr');

[Dan Beam, 2015/07/08 23:41:36]

after you bind(), this should work:

  this.expectCurrentlySelected('fr');

[Julius, 2015/07/09 03:54:52]

Done.

+    testDone();
+  });

[Dan Beam, 2015/07/08 23:41:36]

}.bind(this));

[Julius, 2015/07/09 03:54:51]

Done.

+
+  // Click 'fr' and trigger the previously registered event listener.
+  $('spellcheck-language-checkbox').click();
+

[Dan Beam, 2015/07/08 23:41:37]

remove \n

[Julius, 2015/07/09 03:54:52]

Done.

+});