chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h - Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replied to comments, added browser tests, rebased. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/about_flags.cc ('K') | « chrome/browser/about_flags.cc ('k') | chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc » ('j') | chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h

diff --git a/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h b/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h

index 23b7e8666943065f5566a62c8fa1492d12cfc283..8b7ddf1f5dd303090ace28a6dbf193cae8645f25 100644

--- a/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h

+++ b/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h

@@ -5,6 +5,7 @@

#ifndef CHROME_BROWSER_RENDERER_CONTEXT_MENU_SPELLCHECKER_SUBMENU_OBSERVER_H_

#define CHROME_BROWSER_RENDERER_CONTEXT_MENU_SPELLCHECKER_SUBMENU_OBSERVER_H_

+#include <set>

please use gerrit instead 2015/06/04 19:41:05 Remove unused include.

Julius 2015/06/05 03:41:12 Done.

#include <string>

#include <vector>

@@ -43,7 +44,7 @@ class SpellCheckerSubMenuObserver : public RenderViewContextMenuObserver {

// Hunspell spelling submenu.

// The radio items representing languages available for spellchecking.

int language_group_;

- int language_selected_;

+ int selected_languages_;

please use gerrit instead 2015/06/04 19:41:05 Add a comment on what this variable is. Change it'

Julius 2015/06/05 03:41:12 Done.

std::vector<std::string> languages_;

#endif // !OS_MACOSX