Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted from using any #if defines to exclude Mac compiles. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1981 matching lines...) Expand 10 before | Expand all | Expand 10 after
1992 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableMacViewsNativeAppWindows, 1992 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableMacViewsNativeAppWindows,
1993 switches::kDisableMacViewsNativeAppWindows)}, 1993 switches::kDisableMacViewsNativeAppWindows)},
1994 #endif 1994 #endif
1995 #if defined(ENABLE_WEBVR) 1995 #if defined(ENABLE_WEBVR)
1996 {"enable-webvr", 1996 {"enable-webvr",
1997 IDS_FLAGS_ENABLE_WEBVR_NAME, 1997 IDS_FLAGS_ENABLE_WEBVR_NAME,
1998 IDS_FLAGS_ENABLE_WEBVR_DESCRIPTION, 1998 IDS_FLAGS_ENABLE_WEBVR_DESCRIPTION,
1999 kOsAll, 1999 kOsAll,
2000 SINGLE_VALUE_TYPE(switches::kEnableWebVR)}, 2000 SINGLE_VALUE_TYPE(switches::kEnableWebVR)},
2001 #endif 2001 #endif
2002 // NOTE: Adding new command-line switches requires adding corresponding 2002 #if defined(ENABLE_SPELLCHECK) && \
2003 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2003 (defined(OS_LINUX) || defined(OS_WIN) || defined(OS_CHROMEOS))
2004 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2004 {
2005 "enable-multilingual-spellchecker",
please use gerrit instead 2015/06/23 21:56:01 previous entry is clang-formatted. Maybe clang-for
Julius 2015/06/24 21:17:59 It reformats the whole file but I've reformatted m
2006 IDS_FLAGS_ENABLE_MULTILINGUAL_SPELLCHECKER_NAME,
2007 IDS_FLAGS_ENABLE_MULTILINGUAL_SPELLCHECKER_DESCRIPTION,
2008 kOsWin | kOsLinux | kOsCrOS,
2009 SINGLE_VALUE_TYPE(switches::kEnableMultilingualSpellChecker)
2010 },
2011 #endif
2012 // NOTE: Adding new command-line switches requires adding corresponding
please use gerrit instead 2015/06/23 21:56:00 I think the original comment had 4 spaces. Let's n
Julius 2015/06/24 21:17:59 Done.
2013 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2014 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2005 }; 2015 };
2006 2016
2007 const Experiment* experiments = kExperiments; 2017 const Experiment* experiments = kExperiments;
2008 size_t num_experiments = arraysize(kExperiments); 2018 size_t num_experiments = arraysize(kExperiments);
2009 2019
2010 // Stores and encapsulates the little state that about:flags has. 2020 // Stores and encapsulates the little state that about:flags has.
2011 class FlagsState { 2021 class FlagsState {
2012 public: 2022 public:
2013 FlagsState() : needs_restart_(false) {} 2023 FlagsState() : needs_restart_(false) {}
2014 void ConvertFlagsToSwitches(FlagsStorage* flags_storage, 2024 void ConvertFlagsToSwitches(FlagsStorage* flags_storage,
(...skipping 609 matching lines...) Expand 10 before | Expand all | Expand 10 after
2624 } 2634 }
2625 2635
2626 const Experiment* GetExperiments(size_t* count) { 2636 const Experiment* GetExperiments(size_t* count) {
2627 *count = num_experiments; 2637 *count = num_experiments;
2628 return experiments; 2638 return experiments;
2629 } 2639 }
2630 2640
2631 } // namespace testing 2641 } // namespace testing
2632 2642
2633 } // namespace about_flags 2643 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698