Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: chrome/browser/spellchecker/spellcheck_service.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabled service client when multilingual spellcheck is enabled. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/spellchecker/spellcheck_service.h" 5 #include "chrome/browser/spellchecker/spellcheck_service.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_member.h" 8 #include "base/prefs/pref_member.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
11 #include "base/supports_user_data.h"
11 #include "base/synchronization/waitable_event.h" 12 #include "base/synchronization/waitable_event.h"
12 #include "chrome/browser/spellchecker/feedback_sender.h" 13 #include "chrome/browser/spellchecker/feedback_sender.h"
13 #include "chrome/browser/spellchecker/spellcheck_factory.h" 14 #include "chrome/browser/spellchecker/spellcheck_factory.h"
14 #include "chrome/browser/spellchecker/spellcheck_host_metrics.h" 15 #include "chrome/browser/spellchecker/spellcheck_host_metrics.h"
15 #include "chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h" 16 #include "chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h"
16 #include "chrome/browser/spellchecker/spellcheck_platform_mac.h" 17 #include "chrome/browser/spellchecker/spellcheck_platform_mac.h"
17 #include "chrome/browser/spellchecker/spelling_service_client.h" 18 #include "chrome/browser/spellchecker/spelling_service_client.h"
18 #include "chrome/common/pref_names.h" 19 #include "chrome/common/pref_names.h"
19 #include "chrome/common/spellcheck_common.h" 20 #include "chrome/common/spellcheck_common.h"
20 #include "chrome/common/spellcheck_messages.h" 21 #include "chrome/common/spellcheck_messages.h"
(...skipping 15 matching lines...) Expand all
36 SpellcheckService::EventType g_status_type = 37 SpellcheckService::EventType g_status_type =
37 SpellcheckService::BDICT_NOTINITIALIZED; 38 SpellcheckService::BDICT_NOTINITIALIZED;
38 39
39 SpellcheckService::SpellcheckService(content::BrowserContext* context) 40 SpellcheckService::SpellcheckService(content::BrowserContext* context)
40 : context_(context), 41 : context_(context),
41 weak_ptr_factory_(this) { 42 weak_ptr_factory_(this) {
42 DCHECK_CURRENTLY_ON(BrowserThread::UI); 43 DCHECK_CURRENTLY_ON(BrowserThread::UI);
43 PrefService* prefs = user_prefs::UserPrefs::Get(context); 44 PrefService* prefs = user_prefs::UserPrefs::Get(context);
44 pref_change_registrar_.Init(prefs); 45 pref_change_registrar_.Init(prefs);
45 46
47 std::string locale;
46 std::string language_code; 48 std::string language_code;
47 std::string country_code; 49 std::string country_code;
50 if (chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()) {
51 std::vector<std::string> dictionary_languages;
52 base::SplitString(prefs->GetString(prefs::kSpellCheckDictionaries), ',',
53 &dictionary_languages);
54 locale = dictionary_languages[0];
55 } else {
56 locale = prefs->GetString(prefs::kSpellCheckDictionary);
57 }
58
48 chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale( 59 chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(
49 prefs->GetString(prefs::kSpellCheckDictionary), 60 locale,
50 &language_code, 61 &language_code,
51 &country_code); 62 &country_code);
52 feedback_sender_.reset(new spellcheck::FeedbackSender( 63 feedback_sender_.reset(new spellcheck::FeedbackSender(
53 context->GetRequestContext(), language_code, country_code)); 64 context->GetRequestContext(), language_code, country_code));
54 65
55 pref_change_registrar_.Add( 66 pref_change_registrar_.Add(
56 prefs::kEnableAutoSpellCorrect, 67 prefs::kEnableAutoSpellCorrect,
57 base::Bind(&SpellcheckService::OnEnableAutoSpellCorrectChanged, 68 base::Bind(&SpellcheckService::OnEnableAutoSpellCorrectChanged,
58 base::Unretained(this))); 69 base::Unretained(this)));
59 pref_change_registrar_.Add( 70 if (chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()) {
60 prefs::kSpellCheckDictionary, 71 pref_change_registrar_.Add(
61 base::Bind(&SpellcheckService::OnSpellCheckDictionaryChanged, 72 prefs::kSpellCheckDictionary,
62 base::Unretained(this))); 73 base::Bind(&SpellcheckService::OnSpellCheckDictionaryChanged,
63 pref_change_registrar_.Add( 74 base::Unretained(this)));
64 prefs::kSpellCheckUseSpellingService, 75 } else {
65 base::Bind(&SpellcheckService::OnUseSpellingServiceChanged, 76 pref_change_registrar_.Add(
66 base::Unretained(this))); 77 prefs::kSpellCheckDictionaries,
78 base::Bind(&SpellcheckService::OnSpellCheckDictionaryChanged,
79 base::Unretained(this)));
80 pref_change_registrar_.Add(
81 prefs::kSpellCheckUseSpellingService,
82 base::Bind(&SpellcheckService::OnUseSpellingServiceChanged,
83 base::Unretained(this)));
84 }
67 pref_change_registrar_.Add( 85 pref_change_registrar_.Add(
68 prefs::kEnableContinuousSpellcheck, 86 prefs::kEnableContinuousSpellcheck,
69 base::Bind(&SpellcheckService::InitForAllRenderers, 87 base::Bind(&SpellcheckService::InitForAllRenderers,
70 base::Unretained(this))); 88 base::Unretained(this)));
71 89
72 OnSpellCheckDictionaryChanged(); 90 OnSpellCheckDictionaryChanged();
73 91
74 custom_dictionary_.reset(new SpellcheckCustomDictionary(context_->GetPath())); 92 custom_dictionary_.reset(new SpellcheckCustomDictionary(context_->GetPath()));
75 custom_dictionary_->AddObserver(this); 93 custom_dictionary_->AddObserver(this);
76 custom_dictionary_->Load(); 94 custom_dictionary_->Load();
77 95
78 registrar_.Add(this, 96 registrar_.Add(this,
79 content::NOTIFICATION_RENDERER_PROCESS_CREATED, 97 content::NOTIFICATION_RENDERER_PROCESS_CREATED,
80 content::NotificationService::AllSources()); 98 content::NotificationService::AllSources());
81 } 99 }
82 100
83 SpellcheckService::~SpellcheckService() { 101 SpellcheckService::~SpellcheckService() {
84 // Remove pref observers 102 // Remove pref observers
85 pref_change_registrar_.RemoveAll(); 103 pref_change_registrar_.RemoveAll();
86 } 104 }
87 105
88 base::WeakPtr<SpellcheckService> SpellcheckService::GetWeakPtr() { 106 base::WeakPtr<SpellcheckService> SpellcheckService::GetWeakPtr() {
89 return weak_ptr_factory_.GetWeakPtr(); 107 return weak_ptr_factory_.GetWeakPtr();
90 } 108 }
91 109
110 #if !defined(OS_MACOSX)
92 // static 111 // static
93 int SpellcheckService::GetSpellCheckLanguages( 112 size_t SpellcheckService::GetSpellCheckLanguages(
94 content::BrowserContext* context, 113 base::SupportsUserData* context,
95 std::vector<std::string>* languages) { 114 std::vector<std::string>* languages) {
96 PrefService* prefs = user_prefs::UserPrefs::Get(context); 115 PrefService* prefs = user_prefs::UserPrefs::Get(context);
97 StringPrefMember accept_languages_pref; 116 StringPrefMember accept_languages_pref;
98 StringPrefMember dictionary_language_pref;
99 accept_languages_pref.Init(prefs::kAcceptLanguages, prefs); 117 accept_languages_pref.Init(prefs::kAcceptLanguages, prefs);
100 dictionary_language_pref.Init(prefs::kSpellCheckDictionary, prefs);
101 std::string dictionary_language = dictionary_language_pref.GetValue();
102 118
103 // Now scan through the list of accept languages, and find possible mappings
104 // from this list to the existing list of spell check languages.
105 std::vector<std::string> accept_languages; 119 std::vector<std::string> accept_languages;
120 base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
106 121
107 #if defined(OS_MACOSX) 122 *languages = chrome::spellcheck_common::GetDictionaryLanguagesPref(prefs);
108 if (spellcheck_mac::SpellCheckerAvailable()) 123 size_t enabled_spellcheck_languages = languages->size();
109 spellcheck_mac::GetAvailableLanguages(&accept_languages);
110 else
111 base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
112 #else
113 base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
114 #endif // !OS_MACOSX
115
116 GetSpellCheckLanguagesFromAcceptLanguages(
117 accept_languages, dictionary_language, languages);
118
119 for (size_t i = 0; i < languages->size(); ++i) {
120 if ((*languages)[i] == dictionary_language)
121 return i;
122 }
123 return -1;
124 }
125
126 // static
127 void SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
128 const std::vector<std::string>& accept_languages,
129 const std::string& dictionary_language,
130 std::vector<std::string>* languages) {
131 // The current dictionary language should be there.
132 languages->push_back(dictionary_language);
133 124
134 for (std::vector<std::string>::const_iterator i = accept_languages.begin(); 125 for (std::vector<std::string>::const_iterator i = accept_languages.begin();
135 i != accept_languages.end(); ++i) { 126 i != accept_languages.end(); ++i) {
136 std::string language = 127 std::string language =
137 chrome::spellcheck_common::GetCorrespondingSpellCheckLanguage(*i); 128 chrome::spellcheck_common::GetCorrespondingSpellCheckLanguage(*i);
138 if (!language.empty() && 129 if (!language.empty() &&
139 std::find(languages->begin(), languages->end(), language) == 130 std::find(languages->begin(), languages->end(), language) ==
140 languages->end()) { 131 languages->end()) {
141 languages->push_back(language); 132 languages->push_back(language);
142 } 133 }
143 } 134 }
135
136 return enabled_spellcheck_languages;
144 } 137 }
138 #endif // !OS_MACOSX
145 139
146 // static 140 // static
147 bool SpellcheckService::SignalStatusEvent( 141 bool SpellcheckService::SignalStatusEvent(
148 SpellcheckService::EventType status_type) { 142 SpellcheckService::EventType status_type) {
149 DCHECK_CURRENTLY_ON(BrowserThread::UI); 143 DCHECK_CURRENTLY_ON(BrowserThread::UI);
150 144
151 if (!g_status_event) 145 if (!g_status_event)
152 return false; 146 return false;
153 g_status_type = status_type; 147 g_status_type = status_type;
154 g_status_event->Signal(); 148 g_status_event->Signal();
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 process->Send(new SpellCheckMsg_EnableAutoSpellCorrect(enabled)); 278 process->Send(new SpellCheckMsg_EnableAutoSpellCorrect(enabled));
285 } 279 }
286 } 280 }
287 281
288 void SpellcheckService::OnSpellCheckDictionaryChanged() { 282 void SpellcheckService::OnSpellCheckDictionaryChanged() {
289 if (hunspell_dictionary_.get()) 283 if (hunspell_dictionary_.get())
290 hunspell_dictionary_->RemoveObserver(this); 284 hunspell_dictionary_->RemoveObserver(this);
291 PrefService* prefs = user_prefs::UserPrefs::Get(context_); 285 PrefService* prefs = user_prefs::UserPrefs::Get(context_);
292 DCHECK(prefs); 286 DCHECK(prefs);
293 287
294 std::string dictionary = 288 std::string dictionary;
295 prefs->GetString(prefs::kSpellCheckDictionary); 289 if (chrome::spellcheck_common::IsMultilingualSpellcheckEnabled()) {
290 std::vector<std::string> dictionary_languages;
291 base::SplitString(prefs->GetString(prefs::kSpellCheckDictionaries), ',',
292 &dictionary_languages);
293 if (dictionary_languages.size() <= 0) {
294 return;
295 } else {
296 dictionary = dictionary_languages[0];
297 }
298 } else {
299 dictionary = prefs->GetString(prefs::kSpellCheckDictionary);
300 }
296 hunspell_dictionary_.reset(new SpellcheckHunspellDictionary( 301 hunspell_dictionary_.reset(new SpellcheckHunspellDictionary(
297 dictionary, context_->GetRequestContext(), this)); 302 dictionary, context_->GetRequestContext(), this));
298 hunspell_dictionary_->AddObserver(this); 303 hunspell_dictionary_->AddObserver(this);
299 hunspell_dictionary_->Load(); 304 hunspell_dictionary_->Load();
300 std::string language_code; 305 std::string language_code;
301 std::string country_code; 306 std::string country_code;
302 chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale( 307 chrome::spellcheck_common::GetISOLanguageCountryCodeFromLocale(
303 dictionary, &language_code, &country_code); 308 dictionary, &language_code, &country_code);
304 feedback_sender_->OnLanguageCountryChange(language_code, country_code); 309 feedback_sender_->OnLanguageCountryChange(language_code, country_code);
305 UpdateFeedbackSenderState(); 310 UpdateFeedbackSenderState();
306 } 311 }
307 312
308 void SpellcheckService::OnUseSpellingServiceChanged() { 313 void SpellcheckService::OnUseSpellingServiceChanged() {
309 bool enabled = pref_change_registrar_.prefs()->GetBoolean( 314 bool enabled = pref_change_registrar_.prefs()->GetBoolean(
310 prefs::kSpellCheckUseSpellingService); 315 prefs::kSpellCheckUseSpellingService);
311 if (metrics_) 316 if (metrics_)
312 metrics_->RecordSpellingServiceStats(enabled); 317 metrics_->RecordSpellingServiceStats(enabled);
313 UpdateFeedbackSenderState(); 318 UpdateFeedbackSenderState();
314 } 319 }
315 320
316 void SpellcheckService::UpdateFeedbackSenderState() { 321 void SpellcheckService::UpdateFeedbackSenderState() {
317 if (SpellingServiceClient::IsAvailable( 322 if (SpellingServiceClient::IsAvailable(
318 context_, SpellingServiceClient::SPELLCHECK)) { 323 context_, SpellingServiceClient::SPELLCHECK)) {
319 feedback_sender_->StartFeedbackCollection(); 324 feedback_sender_->StartFeedbackCollection();
320 } else { 325 } else {
321 feedback_sender_->StopFeedbackCollection(); 326 feedback_sender_->StopFeedbackCollection();
322 } 327 }
323 } 328 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698