Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Side by Side Diff: chrome/browser/spellchecker/spellcheck_service.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved spellcheck_service_browsertest to a unittest, cleaned code, replied to comments, stopped Mac … Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/spellchecker/spellcheck_service.h" 5 #include "chrome/browser/spellchecker/spellcheck_service.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_member.h" 8 #include "base/prefs/pref_member.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
11 #include "base/supports_user_data.h"
11 #include "base/synchronization/waitable_event.h" 12 #include "base/synchronization/waitable_event.h"
12 #include "chrome/browser/spellchecker/feedback_sender.h" 13 #include "chrome/browser/spellchecker/feedback_sender.h"
13 #include "chrome/browser/spellchecker/spellcheck_factory.h" 14 #include "chrome/browser/spellchecker/spellcheck_factory.h"
14 #include "chrome/browser/spellchecker/spellcheck_host_metrics.h" 15 #include "chrome/browser/spellchecker/spellcheck_host_metrics.h"
15 #include "chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h" 16 #include "chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h"
16 #include "chrome/browser/spellchecker/spellcheck_platform_mac.h" 17 #include "chrome/browser/spellchecker/spellcheck_platform_mac.h"
17 #include "chrome/browser/spellchecker/spelling_service_client.h" 18 #include "chrome/browser/spellchecker/spelling_service_client.h"
18 #include "chrome/common/pref_names.h" 19 #include "chrome/common/pref_names.h"
19 #include "chrome/common/spellcheck_common.h" 20 #include "chrome/common/spellcheck_common.h"
20 #include "chrome/common/spellcheck_messages.h" 21 #include "chrome/common/spellcheck_messages.h"
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 83
83 SpellcheckService::~SpellcheckService() { 84 SpellcheckService::~SpellcheckService() {
84 // Remove pref observers 85 // Remove pref observers
85 pref_change_registrar_.RemoveAll(); 86 pref_change_registrar_.RemoveAll();
86 } 87 }
87 88
88 base::WeakPtr<SpellcheckService> SpellcheckService::GetWeakPtr() { 89 base::WeakPtr<SpellcheckService> SpellcheckService::GetWeakPtr() {
89 return weak_ptr_factory_.GetWeakPtr(); 90 return weak_ptr_factory_.GetWeakPtr();
90 } 91 }
91 92
93 #if !defined(OS_MACOSX)
92 // static 94 // static
93 int SpellcheckService::GetSpellCheckLanguages( 95 size_t SpellcheckService::GetSpellCheckLanguages(
94 content::BrowserContext* context, 96 base::SupportsUserData* context,
95 std::vector<std::string>* languages) { 97 std::vector<std::string>* languages) {
96 PrefService* prefs = user_prefs::UserPrefs::Get(context); 98 PrefService* prefs = user_prefs::UserPrefs::Get(context);
97 StringPrefMember accept_languages_pref; 99 StringPrefMember accept_languages_pref;
98 StringPrefMember dictionary_language_pref;
99 accept_languages_pref.Init(prefs::kAcceptLanguages, prefs); 100 accept_languages_pref.Init(prefs::kAcceptLanguages, prefs);
100 dictionary_language_pref.Init(prefs::kSpellCheckDictionary, prefs);
101 std::string dictionary_language = dictionary_language_pref.GetValue();
102 101
103 // Now scan through the list of accept languages, and find possible mappings
104 // from this list to the existing list of spell check languages.
105 std::vector<std::string> accept_languages; 102 std::vector<std::string> accept_languages;
103 base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
106 104
107 #if defined(OS_MACOSX) 105 *languages = chrome::spellcheck_common::GetDictionaryLanguagesPref(prefs);
108 if (spellcheck_mac::SpellCheckerAvailable()) 106 size_t enabled_spellcheck_languages = languages->size();
109 spellcheck_mac::GetAvailableLanguages(&accept_languages);
110 else
111 base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
112 #else
113 base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
114 #endif // !OS_MACOSX
115
116 GetSpellCheckLanguagesFromAcceptLanguages(
117 accept_languages, dictionary_language, languages);
118
119 for (size_t i = 0; i < languages->size(); ++i) {
120 if ((*languages)[i] == dictionary_language)
121 return i;
122 }
123 return -1;
124 }
125
126 // static
127 void SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
128 const std::vector<std::string>& accept_languages,
129 const std::string& dictionary_language,
130 std::vector<std::string>* languages) {
131 // The current dictionary language should be there.
132 languages->push_back(dictionary_language);
133 107
134 for (std::vector<std::string>::const_iterator i = accept_languages.begin(); 108 for (std::vector<std::string>::const_iterator i = accept_languages.begin();
135 i != accept_languages.end(); ++i) { 109 i != accept_languages.end(); ++i) {
136 std::string language = 110 std::string language =
137 chrome::spellcheck_common::GetCorrespondingSpellCheckLanguage(*i); 111 chrome::spellcheck_common::GetCorrespondingSpellCheckLanguage(*i);
138 if (!language.empty() && 112 if (!language.empty() &&
139 std::find(languages->begin(), languages->end(), language) == 113 std::find(languages->begin(), languages->end(), language) ==
140 languages->end()) { 114 languages->end()) {
141 languages->push_back(language); 115 languages->push_back(language);
142 } 116 }
143 } 117 }
118
119 return enabled_spellcheck_languages;
144 } 120 }
121 #endif // !OS_MACOSX
145 122
146 // static 123 // static
147 bool SpellcheckService::SignalStatusEvent( 124 bool SpellcheckService::SignalStatusEvent(
148 SpellcheckService::EventType status_type) { 125 SpellcheckService::EventType status_type) {
149 DCHECK_CURRENTLY_ON(BrowserThread::UI); 126 DCHECK_CURRENTLY_ON(BrowserThread::UI);
150 127
151 if (!g_status_event) 128 if (!g_status_event)
152 return false; 129 return false;
153 g_status_type = status_type; 130 g_status_type = status_type;
154 g_status_event->Signal(); 131 g_status_event->Signal();
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 } 291 }
315 292
316 void SpellcheckService::UpdateFeedbackSenderState() { 293 void SpellcheckService::UpdateFeedbackSenderState() {
317 if (SpellingServiceClient::IsAvailable( 294 if (SpellingServiceClient::IsAvailable(
318 context_, SpellingServiceClient::SPELLCHECK)) { 295 context_, SpellingServiceClient::SPELLCHECK)) {
319 feedback_sender_->StartFeedbackCollection(); 296 feedback_sender_->StartFeedbackCollection();
320 } else { 297 } else {
321 feedback_sender_->StopFeedbackCollection(); 298 feedback_sender_->StopFeedbackCollection();
322 } 299 }
323 } 300 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698