Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/spellchecker/spellcheck_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellchecker/spellcheck_factory.h"
 
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/profiles/incognito_helpers.h"
 #include "chrome/browser/spellchecker/spellcheck_service.h"
 #include "chrome/common/pref_names.h"
+#include "chrome/common/spellcheck_common.h"
 #include "chrome/grit/locale_settings.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/user_prefs/user_prefs.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/render_process_host.h"
 #include "ui/base/l10n/l10n_util.h"
 
 // static
 SpellcheckService* SpellcheckServiceFactory::GetForContext(
@@ skipping 27 matching lines @@
   // TODO(erg): Uncomment these as they are initialized.
   // DependsOn(RequestContextFactory::GetInstance());
 }
 
 SpellcheckServiceFactory::~SpellcheckServiceFactory() {}
 
 KeyedService* SpellcheckServiceFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
   // Many variables are initialized from the |context| in the SpellcheckService.
   SpellcheckService* spellcheck = new SpellcheckService(context);
-

[please use gerrit instead, 2015/06/16 00:31:16]

These whitespace changes or not necessary.

[Julius, 2015/06/17 00:59:52]

Done.

   PrefService* prefs = user_prefs::UserPrefs::Get(context);
   DCHECK(prefs);
 
   // Instantiates Metrics object for spellchecking for use.
   spellcheck->StartRecordingMetrics(
       prefs->GetBoolean(prefs::kEnableContinuousSpellcheck));
-
   return spellcheck;
 }
 
 void SpellcheckServiceFactory::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* user_prefs) {
   // TODO(estade): IDS_SPELLCHECK_DICTIONARY should be an ASCII string.
+
+  // TODO(juliusa): Implement preference migration between multilingual
+  // spellchecking and single-language spellchecking.

[please use gerrit instead, 2015/06/16 00:31:16]

You can put this on your own todo list, but let's not add TODOs in code :-)

[Julius, 2015/06/17 00:59:52]

Done.

+  if (chrome::spellcheck_common::MultilingualSpellcheckIsEnabled()) {
+    user_prefs->RegisterStringPref(
+        prefs::kSpellCheckDictionaries,
+        l10n_util::GetStringUTF8(IDS_SPELLCHECK_DICTIONARY),
+        user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
+  } else {

[please use gerrit instead, 2015/06/16 00:31:16]

Is that an empty else{} block?

[Julius, 2015/06/17 00:59:52]

Done.

+  }
   user_prefs->RegisterStringPref(
-      prefs::kSpellCheckDictionary,
-      l10n_util::GetStringUTF8(IDS_SPELLCHECK_DICTIONARY));
+    prefs::kSpellCheckDictionary,
+    l10n_util::GetStringUTF8(IDS_SPELLCHECK_DICTIONARY),
+    user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
+
   user_prefs->RegisterBooleanPref(prefs::kSpellCheckUseSpellingService, false);
   user_prefs->RegisterBooleanPref(
       prefs::kEnableContinuousSpellcheck,
       true,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   user_prefs->RegisterBooleanPref(
       prefs::kEnableAutoSpellCorrect,
       false,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 }
 
 content::BrowserContext* SpellcheckServiceFactory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return chrome::GetBrowserContextRedirectedInIncognito(context);
 }
 
 bool SpellcheckServiceFactory::ServiceIsNULLWhileTesting() const {
   return true;
 }