Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1156473007: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments, clarified code. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2397 matching lines...) Expand 10 before | Expand all | Expand 10 after
2408 #if defined(OS_MACOSX) 2408 #if defined(OS_MACOSX)
2409 { 2409 {
2410 "app-info-dialog", 2410 "app-info-dialog",
2411 IDS_FLAGS_APP_INFO_DIALOG_NAME, 2411 IDS_FLAGS_APP_INFO_DIALOG_NAME,
2412 IDS_FLAGS_APP_INFO_DIALOG_DESCRIPTION, 2412 IDS_FLAGS_APP_INFO_DIALOG_DESCRIPTION,
2413 kOsMac, 2413 kOsMac,
2414 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAppInfoDialogMac, 2414 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAppInfoDialogMac,
2415 switches::kDisableAppInfoDialogMac) 2415 switches::kDisableAppInfoDialogMac)
2416 }, 2416 },
2417 #endif 2417 #endif
2418 #if defined(ENABLE_SPELLCHECK) && \
2419 (defined(OS_LINUX) || defined(OS_WIN) || defined(OS_CHROMEOS))
2420 {
2421 "enable-multilingual-spellchecker",
2422 IDS_FLAGS_ENABLE_MULTILINGUAL_SPELLCHECKER_NAME,
2423 IDS_FLAGS_ENABLE_MULTILINGUAL_SPELLCHECKER_DESCRIPTION,
2424 kOsWin | kOsLinux | kOsCrOS,
2425 SINGLE_VALUE_TYPE(switches::kEnableMultilingualSpellChecker)
2426 },
2427 #endif
2428
2418 // NOTE: Adding new command-line switches requires adding corresponding 2429 // NOTE: Adding new command-line switches requires adding corresponding
2419 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2430 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2420 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2431 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2421 }; 2432 };
2422 2433
2423 const Experiment* experiments = kExperiments; 2434 const Experiment* experiments = kExperiments;
2424 size_t num_experiments = arraysize(kExperiments); 2435 size_t num_experiments = arraysize(kExperiments);
2425 2436
2426 // Stores and encapsulates the little state that about:flags has. 2437 // Stores and encapsulates the little state that about:flags has.
2427 class FlagsState { 2438 class FlagsState {
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
3005 } 3016 }
3006 3017
3007 const Experiment* GetExperiments(size_t* count) { 3018 const Experiment* GetExperiments(size_t* count) {
3008 *count = num_experiments; 3019 *count = num_experiments;
3009 return experiments; 3020 return experiments;
3010 } 3021 }
3011 3022
3012 } // namespace testing 3023 } // namespace testing
3013 3024
3014 } // namespace about_flags 3025 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698