Source/web/tests/WebFrameTest.cpp - Issue 1156473002: Refactor FrameLoader loading interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 1156473002: Refactor FrameLoader loading interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index c7a5791205a0d1655397e6f8b05c6dbb4e049fab..df08c02c744b2b8502bb081a66d8873a932d2dc2 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -5905,7 +5905,10 @@ TEST_P(ParametrizedWebFrameTest, SameDocumentHistoryNavigationCommitType)

RefPtrWillBePersistent<HistoryItem> item = toLocalFrame(webViewImpl->page()->mainFrame())->loader().currentItem();

runPendingTasks();

- toLocalFrame(webViewImpl->page()->mainFrame())->loader().loadHistoryItem(item.get(), FrameLoadTypeBackForward, HistorySameDocumentLoad);

+ toLocalFrame(webViewImpl->page()->mainFrame())->loader().load(

+ FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(

+ item.get(), UseProtocolCachePolicy)),

+ FrameLoadTypeBackForward, item.get(), HistorySameDocumentLoad);

EXPECT_EQ(WebBackForwardCommit, client.lastCommitType());

}