Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1156463004: Revert of scheduler: Always create a real scheduler in unit tests (Closed)

Created:
5 years, 6 months ago by tkent
Modified:
5 years, 6 months ago
CC:
chromium-reviews, jam, scheduler-bugs_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of scheduler: Always create a real scheduler in unit tests (patchset #10 id:180001 of https://codereview.chromium.org/1152623008/) Reason for revert: Caused crashes of webkit_unit_tests. e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/48714 Original issue's description: > scheduler: Always create a real scheduler in unit tests > > Previously we would create a dummy scheduler in any test which uses > TestBlinkWebUnitTestSupport without first initializing a message loop. > This causes problems because the dummy scheduler ignores all tasks it > is given. > > This patch makes the tests more realistic by always creating a real > renderer scheduler regardless of whether we have a message loop or not. > This is achieved by lazily binding the scheduler to the message loop > the first time it is needed. > > Longer term we would like to refactor these test suites to ensure Blink > always has a valid message loop when it is initialized, but this will > involve rewiring several tests. > > BUG=463143, 495659 > > Committed: https://crrev.com/087644f1eab41927823a1a2fc2df08bd4e10fe18 > Cr-Commit-Position: refs/heads/master@{#332685} TBR=rmcilroy@chromium.org,alexclarke@chromium.org,sievers@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463143, 495659 Committed: https://crrev.com/1c9dfd53fee588bdca753d2ccc1be7a47011afd1 Cr-Commit-Position: refs/heads/master@{#332758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -177 lines) Patch
M components/scheduler/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M components/scheduler/scheduler.gyp View 1 chunk +0 lines, -11 lines 0 comments Download
M components/scheduler/scheduler.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
D components/scheduler/test/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h View 1 chunk +0 lines, -55 lines 0 comments Download
D components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 5 chunks +38 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of scheduler: Always create a real scheduler in unit tests
5 years, 6 months ago (2015-06-04 01:27:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156463004/1
5 years, 6 months ago (2015-06-04 01:28:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 01:30:01 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 01:30:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c9dfd53fee588bdca753d2ccc1be7a47011afd1
Cr-Commit-Position: refs/heads/master@{#332758}

Powered by Google App Engine
This is Rietveld 408576698