Issue 1156463003: Oilpan: fix build after r196422.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1156463003: Oilpan: fix build after r196422. (Closed)

Created:
5 years, 6 months ago by sof

Modified:
5 years, 6 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: fix build after r196422. TBR=oilpan-reviews BUG=466631 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196426

Patch Set 1 #

Patch Set 2 : V8Debugger fixes #

Patch Set 3 : InspectorDebuggerAgent fixes #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
M	Source/bindings/core/v8/V8Debugger.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/core/v8/V8Debugger.cpp	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/inspector/InspectorDebuggerAgent.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorDebuggerAgent.cpp	View	1 2	5 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/inspector/JavaScriptCallFrame.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

please take a look. oilpan-review's offer to quickly look over CLs that touch on Oilpan ...

5 years, 6 months ago (2015-06-03 20:16:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156463003/40001

5 years, 6 months ago (2015-06-03 20:17:39 UTC) #3

commit-bot: I haz the power

Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196426

5 years, 6 months ago (2015-06-03 20:23:20 UTC) #4

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages