Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2812)

Unified Diff: build/gyp_chromium

Issue 115643002: Hook up GN official build and branding. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index e4acd8850ac9ebee633dd441e7d4d6da6f59ef57..978ce4af5a3e8fb1bd88145bdcf7f5ef052de3b0 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -115,12 +115,19 @@ def GetArgsStringForGN(supplemental_files):
vars_dict = GetGypVarsForGN(supplemental_files)
gn_args = ''
- # Map "component=shared_library" to "is_component_build=true"
- if "component" in vars_dict and vars_dict["component"] == "shared_library":
- gn_args += ' is_component_build=true'
+ # These tuples of (key, value, gn_arg_string) use the gn_arg_string for
+ # gn when the key is set to the given value in the GYP arguments.
+ remap_cases = [
+ ('branding', 'Chrome', 'is_chrome_branded=true'),
+ ('buildtype', 'Official', 'is_official_build=true'),
+ ('component', 'shared_library', 'is_component_build=true'),
+ ]
+ for i in remap_cases:
+ if i[0] in vars_dict and vars_dict[i[0]] == i[1]:
+ gn_args += ' ' + i[2]
# These string arguments get passed directly.
- for v in ['window_sdk_path']:
+ for v in ['windows_sdk_path']:
if v in vars_dict:
gn_args += ' ' + v + '="' + EscapeStringForGN(vars_dict[v]) + '"'

Powered by Google App Engine
This is Rietveld 408576698