Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1790)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 11564034: Revert r16154: some browser tests in checked mode fail. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 16156)
+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)
@@ -2291,11 +2291,6 @@
push(new js.Binary('==', pop(), new js.LiteralNull()));
}
- void checkNonNull(HInstruction input) {
- use(input);
- push(new js.Binary('!=', pop(), new js.LiteralNull()));
- }
-
void checkFunction(HInstruction input, DartType type) {
checkTypeOf(input, '===', 'function');
js.Expression functionTest = pop();
@@ -2420,12 +2415,6 @@
|| Elements.isListSupertype(element, compiler)) {
handleListOrSupertypeCheck(input, type);
attachLocationToLast(node);
- } else if (element.isTypedef()) {
- checkNonNull(input);
- js.Expression nullTest = pop();
- checkType(input, type);
- push(new js.Binary('&&', nullTest, pop()));
- attachLocationToLast(node);
} else if (types[input].canBePrimitive() || types[input].canBeNull()) {
checkObject(input, '===');
js.Expression objectTest = pop();
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698