Revert r16154: some browser tests in checked mode fail.

sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * A function element that represents a closure call. The signature is copied
  * from the given element.
  */
@@ skipping 1094 matching lines @@
                           new js.VariableUse('receiver')
                               .dot(name)
                               .callWith(arguments))]));
 
       CodeBuffer code = new CodeBuffer();
       code.add(js.prettyPrint(function, compiler));
       defineInstanceMember(name, code);
     }
   }
 
-  void emitTypedefChecksOn(DartType type, void emitTest(Element element)) {
-    for (TypedefElement typedef in checkedTypedefs) {
-      FunctionType typedefType =
-          typedef.computeType(compiler).unalias(compiler);
-      if (compiler.types.isSubtype(type, typedefType)) {
-        emitTest(typedef);
-      }
-    }
-  }
-
   /**
    * Generate "is tests" for [cls]: itself, and the "is tests" for the
    * classes it implements. We don't need to add the "is tests" of the
    * super class because they will be inherited at runtime.
    */
   void generateIsTestsOn(ClassElement cls,
                          void emitIsTest(Element element)) {
     if (checkedClasses.contains(cls)) {
       emitIsTest(cls);
     }
 
     Set<Element> generated = new Set<Element>();
     // A class that defines a [:call:] method implicitly implements
     // [Function] and needs checks for all typedefs that are used in is-checks.
     if (checkedClasses.contains(compiler.functionClass) ||
         !checkedTypedefs.isEmpty) {
       FunctionElement call = cls.lookupLocalMember(Compiler.CALL_OPERATOR_NAME);
       if (call == null) {
         // If [cls] is a closure, it has a synthetic call operator method.
         call = cls.lookupBackendMember(Compiler.CALL_OPERATOR_NAME);
       }
       if (call != null) {
         generateInterfacesIsTests(compiler.functionClass,
                                   emitIsTest,
                                   generated);
-        emitTypedefChecksOn(call.computeType(compiler), emitIsTest);
+        FunctionType callType = call.computeType(compiler);
+        for (TypedefElement typedef in checkedTypedefs) {
+          FunctionType typedefType =
+              typedef.computeType(compiler).unalias(compiler);
+          if (compiler.types.isSubtype(callType, typedefType)) {
+            emitIsTest(typedef);
+          }
+        }
       }
     }
     for (DartType interfaceType in cls.interfaces) {
       generateInterfacesIsTests(interfaceType.element, emitIsTest, generated);
     }
   }
 
   /**
    * Generate "is tests" where [cls] is being implemented.
    */
@@ skipping 117 matching lines @@
 
   void emitStaticFunctionWithNamer(CodeBuffer buffer,
                                    Element element,
                                    CodeBuffer functionBuffer,
                                    String functionNamer(Element element)) {
     String functionName = functionNamer(element);
     buffer.add('$isolateProperties.$functionName$_=$_');
     buffer.add(functionBuffer);
     buffer.add('$N$n');
   }
-
   void emitStaticFunctionsWithNamer(CodeBuffer buffer,
                                     Map<Element, CodeBuffer> generatedCode,
                                     String functionNamer(Element element)) {
     generatedCode.forEach((Element element, CodeBuffer functionBuffer) {
       if (!element.isInstanceMember() && !element.isField()) {
         emitStaticFunctionWithNamer(
             buffer, element, functionBuffer,functionNamer);
       }
     });
   }
@@ skipping 22 matching lines @@
       String invocationName = namer.instanceMethodName(callElement);
       String fieldAccess = '$isolateProperties.$staticName';
       buffer.add("$fieldAccess.$invocationName$_=$_$fieldAccess$N");
       addParameterStubs(callElement, (String name, CodeBuffer value) {
         buffer.add('$fieldAccess.$name$_=$_$value$N');
       });
       // If a static function is used as a closure we need to add its name
       // in case it is used in spawnFunction.
       String fieldName = namer.STATIC_CLOSURE_NAME_NAME;
       buffer.add('$fieldAccess.$fieldName$_=$_"$staticName"$N');
-      emitTypedefChecksOn(element.computeType(compiler), (Element typedef) {
-        String operator = namer.operatorIs(typedef);
-        buffer.add('$fieldAccess.$operator$_=${_}true$N');
-      });
     }
   }
 
   void emitBoundClosureClassHeader(String mangledName,
                                    String superName,
                                    List<String> fieldNames,
                                    CodeBuffer buffer) {
     buffer.add('$classesCollector.$mangledName$_=$_'
                '{"":"$superName;${Strings.join(fieldNames,',')}",');
   }
@@ skipping 93 matching lines @@
                               new js.This().dot(fieldNames[0]),
                               new js.This().dot(fieldNames[1]))
                           .callWith(arguments))]));
 
       boundClosureBuffer.add(
           '$_$invocationName:$_${js.prettyPrint(fun,compiler)}');
 
       addParameterStubs(callElement, (String stubName, CodeBuffer memberValue) {
         boundClosureBuffer.add(',\n$_$stubName:$_$memberValue');
       });
-
-      emitTypedefChecksOn(member.computeType(compiler), (Element typedef) {
-        String operator = namer.operatorIs(typedef);
-        boundClosureBuffer.add(',\n$_$operator$_:${_}true');
-      });
-
       boundClosureBuffer.add("$n}$N");
 
       closureClass = namer.isolateAccess(closureClassElement);
 
       // Cache it.
       if (!hasOptionalParameters) {
         cache[parameterCount] = closureClass;
       }
     }
 
@@ skipping 617 matching lines @@
 """;
 const String HOOKS_API_USAGE = """
 // The code supports the following hooks:
 // dartPrint(message)   - if this function is defined it is called
 //                        instead of the Dart [print] method.
 // dartMainRunner(main) - if this function is defined, the Dart [main]
 //                        method will not be invoked directly.
 //                        Instead, a closure that will invoke [main] is
 //                        passed to [dartMainRunner].
 """;