Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1156403002: [turbofan] Record SharedFunctionInfo of inlined functions. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Record SharedFunctionInfo of inlined functions. We need the shared function info of inlined functions to prevent code flushing for their unoptimized code, and also to make sure that liveedit can find the proper functions to deoptimize. R=jarin@chromium.org Committed: https://crrev.com/ce2b39f2f26901ba060d7316ff8d9bfa172acff8 Cr-Commit-Position: refs/heads/master@{#28677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -16 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/code-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 3 chunks +14 lines, -1 line 0 comments Download
M src/compiler/common-operator.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M src/compiler/frame-states.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/compiler/frame-states.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/instruction.h View 4 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/instruction.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-28 11:36:54 UTC) #1
Benedikt Meurer
Hey Jaro, This is the fix we discussed earlier. Now TurboFan is also safe wrt. ...
5 years, 7 months ago (2015-05-28 11:37:54 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-05-28 12:11:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156403002/1
5 years, 6 months ago (2015-05-28 12:11:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 12:12:48 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 12:13:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce2b39f2f26901ba060d7316ff8d9bfa172acff8
Cr-Commit-Position: refs/heads/master@{#28677}

Powered by Google App Engine
This is Rietveld 408576698