Implement Function.apply in vm (issue 5670).

runtime/vm/code_generator.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler_macros.h"
 #include "vm/ast.h"
 #include "vm/bigint_operations.h"
 #include "vm/code_patcher.h"
@@ skipping 748 matching lines @@
   StackFrame* caller_frame = iterator.NextFrame();
   ASSERT(caller_frame != NULL);
   const Code& caller_code = Code::Handle(caller_frame->LookupDartCode());
   ASSERT(!caller_code.IsNull());
   const Function& target_function = Function::Handle(
       caller_code.GetStaticCallTargetFunctionAt(caller_frame->pc()));
   if (!target_function.HasCode()) {
     const Error& error =
         Error::Handle(Compiler::CompileFunction(target_function));
     if (!error.IsNull()) {
       Exceptions::PropagateError(error);

[siva, 2012/12/14 18:30:25]

PropagateError already has an UNREACHABLE().

[regis, 2012/12/14 18:49:49]

Done.

+      UNREACHABLE();
     }
   }
   const Code& target_code = Code::Handle(target_function.CurrentCode());
   // Before patching verify that we are not repeatedly patching to the same
   // target.
   ASSERT(target_code.EntryPoint() !=
          CodePatcher::GetStaticCallTargetAt(caller_frame->pc()));
   CodePatcher::PatchStaticCallAt(caller_frame->pc(), target_code.EntryPoint());
   caller_code.SetStaticCallTargetCodeAt(caller_frame->pc(), target_code);
   if (FLAG_trace_patching) {
@@ skipping 24 matching lines @@
                                       function_name,
                                       num_arguments,
                                       num_named_arguments);
   if (function.IsNull()) {
     return Code::null();
   } else {
     if (!function.HasCode()) {
       const Error& error = Error::Handle(Compiler::CompileFunction(function));
       if (!error.IsNull()) {
         Exceptions::PropagateError(error);
+        UNREACHABLE();
       }
     }
     return function.CurrentCode();
   }
 }
 
 
 // Result of an invoke may be an unhandled exception, in which case we
 // rethrow it.
 static void CheckResultError(const Object& result) {
   if (result.IsError()) {
     Exceptions::PropagateError(Error::Cast(result));
+    UNREACHABLE();
   }
 }
 
 
 // Gets called from debug stub when code reaches a breakpoint.
 DEFINE_RUNTIME_ENTRY(BreakpointStaticHandler, 0) {
   ASSERT(arguments.ArgCount() ==
       kBreakpointStaticHandlerRuntimeEntry.argument_count());
   ASSERT(isolate->debugger() != NULL);
   isolate->debugger()->SignalBpReached();
   // Make sure the static function that is about to be called is
   // compiled. The stub will jump to the entry point without any
   // further tests.
   DartFrameIterator iterator;
   StackFrame* caller_frame = iterator.NextFrame();
   ASSERT(caller_frame != NULL);
   const Code& code = Code::Handle(caller_frame->LookupDartCode());
   const Function& function =
       Function::Handle(code.GetStaticCallTargetFunctionAt(caller_frame->pc()));
 
   if (!function.HasCode()) {
     const Error& error = Error::Handle(Compiler::CompileFunction(function));
     if (!error.IsNull()) {
       Exceptions::PropagateError(error);
+      UNREACHABLE();
     }
   }
   arguments.SetReturn(Code::ZoneHandle(function.CurrentCode()));
 }
 
 
 // Gets called from debug stub when code reaches a breakpoint at a return
 // in Dart code.
 DEFINE_RUNTIME_ENTRY(BreakpointReturnHandler, 0) {
   ASSERT(arguments.ArgCount() ==
@@ skipping 174 matching lines @@
       arg_count - Smi::Cast(Object::Handle(descriptor.At(1))).Value();
   const Function& target = Function::Handle(
       Resolver::ResolveDynamicForReceiverClass(cls,
                                                name,
                                                arg_count,
                                                named_arg_count));
 
   Instructions& instructions = Instructions::Handle();
   if (!target.IsNull()) {
     if (!target.HasCode()) {
-      const Error& error =
-          Error::Handle(Compiler::CompileFunction(target));
-      if (!error.IsNull()) Exceptions::PropagateError(error);
+      const Error& error = Error::Handle(Compiler::CompileFunction(target));
+      if (!error.IsNull()) {
+        Exceptions::PropagateError(error);
+        UNREACHABLE();
+      }
     }
     ASSERT(target.HasCode());
     instructions = Code::Handle(target.CurrentCode()).instructions();
   }
   arguments.SetReturn(instructions);
   if (instructions.IsNull()) return;
 
   cache.EnsureCapacity();
   const Smi& class_id = Smi::Handle(Smi::New(cls.id()));
   cache.Insert(class_id, target);
@@ skipping 152 matching lines @@
     }
 
     current_class = current_class.SuperClass();
   } while (!current_class.IsNull());
 
   const Object& null_object = Object::Handle();
   GrowableArray<const Object*> dart_arguments(5);
   dart_arguments.Add(&receiver);
   dart_arguments.Add(&call_symbol);
   dart_arguments.Add(&arguments);
-  dart_arguments.Add(&null_object);
+  dart_arguments.Add(&null_object);  // TODO(regis): Provide names.
   // If a function "call" with different arguments exists, it will have been
   // invoked above, so no need to handle this case here.
   Exceptions::ThrowByType(Exceptions::kNoSuchMethod, dart_arguments);
   UNREACHABLE();
   return Object::null();
 }
 
 
 // An instance call of the form o.f(...) could not be resolved.  Check if
 // there is a getter with the same name.  If so, invoke it.  If the value is
@@ skipping 301 matching lines @@
       (strstr(function.ToFullyQualifiedCString(),
               FLAG_optimization_filter) == NULL)) {
     function.set_usage_counter(kLowInvocationCount);
     return;
   }
   if (function.is_optimizable()) {
     const Error& error =
         Error::Handle(Compiler::CompileOptimizedFunction(function));
     if (!error.IsNull()) {
       Exceptions::PropagateError(error);
+      UNREACHABLE();
     }
     const Code& optimized_code = Code::Handle(function.CurrentCode());
     ASSERT(!optimized_code.IsNull());
     // Set usage counter for reoptimization.
     function.set_usage_counter(
         function.usage_counter() - FLAG_reoptimization_counter_threshold);
   } else {
     if (FLAG_trace_failed_optimization_attempts) {
       PrintCaller("Not Optimizable");
     }
@@ skipping 389 matching lines @@
   Isolate* isolate = Isolate::Current();
   StackZone zone(isolate);
   HANDLESCOPE(isolate);
   const Bigint& big_left = Bigint::Handle(left);
   const Bigint& big_right = Bigint::Handle(right);
   return BigintOperations::Compare(big_left, big_right);
 }
 END_LEAF_RUNTIME_ENTRY
 
 }  // namespace dart