Implement Function.apply in vm (issue 5670).

runtime/vm/code_generator.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler_macros.h"
 #include "vm/ast.h"
 #include "vm/bigint_operations.h"
 #include "vm/code_patcher.h"
@@ skipping 1023 matching lines @@
       arg_count - Smi::Cast(Object::Handle(descriptor.At(1))).Value();
   const Function& target = Function::Handle(
       Resolver::ResolveDynamicForReceiverClass(cls,
                                                name,
                                                arg_count,
                                                named_arg_count));
 
   Instructions& instructions = Instructions::Handle();
   if (!target.IsNull()) {
     if (!target.HasCode()) {
-      const Error& error =
-          Error::Handle(Compiler::CompileFunction(target));
-      if (!error.IsNull()) Exceptions::PropagateError(error);
+      const Error& error = Error::Handle(Compiler::CompileFunction(target));
+      if (!error.IsNull()) {
+        Exceptions::PropagateError(error);
+      }
     }
     ASSERT(target.HasCode());
     instructions = Code::Handle(target.CurrentCode()).instructions();
   }
   arguments.SetReturn(instructions);
   if (instructions.IsNull()) return;
 
   cache.EnsureCapacity();
   const Smi& class_id = Smi::Handle(Smi::New(cls.id()));
   cache.Insert(class_id, target);
@@ skipping 64 matching lines @@
   }
   return closure.raw();
 }
 
 
 static RawInstructions* EnsureCompiled(const Function& function) {
   if (!function.HasCode()) {
     const Error& error = Error::Handle(Compiler::CompileFunction(function));
     if (!error.IsNull()) {
       Exceptions::PropagateError(error);
-      UNREACHABLE();
     }
   }
   const Code& code = Code::Handle(function.CurrentCode());
   ASSERT(!code.IsNull());
   const Instructions& instrs = Instructions::Handle(code.instructions());
   ASSERT(!instrs.IsNull());
   return instrs.raw();
 }
 
 
@@ skipping 67 matching lines @@
     }
 
     current_class = current_class.SuperClass();
   } while (!current_class.IsNull());
 
   const Object& null_object = Object::Handle();
   GrowableArray<const Object*> dart_arguments(5);
   dart_arguments.Add(&receiver);
   dart_arguments.Add(&call_symbol);
   dart_arguments.Add(&arguments);
-  dart_arguments.Add(&null_object);
+  dart_arguments.Add(&null_object);  // TODO(regis): Provide names.
   // If a function "call" with different arguments exists, it will have been
   // invoked above, so no need to handle this case here.
   Exceptions::ThrowByType(Exceptions::kNoSuchMethod, dart_arguments);
   UNREACHABLE();
   return Object::null();
 }
 
 
 // An instance call of the form o.f(...) could not be resolved.  Check if
 // there is a getter with the same name.  If so, invoke it.  If the value is
@@ skipping 24 matching lines @@
                                               getter,
                                               invoke_arguments,
                                               kNoArgumentNames));
 
   // 3. If the getter threw an exception, treat it as no such method.
   if (value.IsUnhandledException()) return false;
 
   // 4. If there was some other error, propagate it.
   if (value.IsError()) {
     Exceptions::PropagateError(Error::Cast(value));
-    UNREACHABLE();
   }
 
   // 5. If the value is a closure, invoke it and return the result.  If it
   // is a non-closure, invoke "call" on it and return the result.
   Instance& instance = Instance::Handle();
   instance ^= value.raw();
   const Class& instance_class = Class::Handle(instance.clazz());
   ASSERT(!instance_class.IsNull());
   // An object is a closure iff. its class has a non-null signature function.
   if (instance_class.signature_function() != Function::null()) {
@@ skipping 665 matching lines @@
   Isolate* isolate = Isolate::Current();
   StackZone zone(isolate);
   HANDLESCOPE(isolate);
   const Bigint& big_left = Bigint::Handle(left);
   const Bigint& big_right = Bigint::Handle(right);
   return BigintOperations::Compare(big_left, big_right);
 }
 END_LEAF_RUNTIME_ENTRY
 
 }  // namespace dart