Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/core_patch.dart

Issue 11564013: Wat if you closure identical? (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/identical_patch.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | tests/language/identical_closure_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/lib/core_patch.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/lib/core_patch.dart (revision 16094)
+++ sdk/lib/_internal/compiler/implementation/lib/core_patch.dart (working copy)
@@ -213,6 +213,6 @@
}
// Patch for 'identical' function.
-patch bool identical(Object a, Object b) {
- throw new Error('Should not reach the body of identical');
-}
+// This is very magic: the compiler knows how to optimize a call to
kasperl 2012/12/13 14:23:23 magic -> magical
ngeoffray 2012/12/13 14:25:00 Done.
+// identical, so we can just express identical with itself.
kasperl 2012/12/13 14:23:23 with -> in terms of
ngeoffray 2012/12/13 14:25:00 Done.
+patch bool identical(Object a, Object b) => identical(a, b);
« no previous file with comments | « runtime/lib/identical_patch.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | tests/language/identical_closure_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698