Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1156393003: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/spdy (Closed)

Created:
5 years, 6 months ago by HariS
Modified:
5 years, 6 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/spdy BUG=457697 Committed: https://crrev.com/2dff98d766305133f520d6732f3edec1baf28985 Cr-Commit-Position: refs/heads/master@{#333060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/spdy/spdy_stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
HariS
Please review the changes.
5 years, 6 months ago (2015-06-02 05:13:57 UTC) #2
mmenke
LGTM
5 years, 6 months ago (2015-06-02 13:20:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156393003/1
5 years, 6 months ago (2015-06-03 04:31:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/89851)
5 years, 6 months ago (2015-06-03 06:07:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156393003/1
5 years, 6 months ago (2015-06-05 15:16:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 16:15:29 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 16:16:26 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2dff98d766305133f520d6732f3edec1baf28985
Cr-Commit-Position: refs/heads/master@{#333060}

Powered by Google App Engine
This is Rietveld 408576698