Substituting ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in chrome/bro…

Use push_back(ptr.Pass()) instead of push_back(ptr.release())

This converts all files in chrome/browser/renderer_host

BUG=457697
Committed: https://crrev.com/af730bf4ae6622680c6955b9d17084e4f4a29380
Cr-Commit-Position: refs/heads/master@{#333444}

[HariS, 2015-05-29 06:32:47]

hari.singh1@samsung.com changed reviewers:
+ mek@chromium.org, miket@chromium.org

[HariS, 2015-05-29 06:32:48]

Please review the changes done.

[HariS, 2015-06-02 09:26:36]

On 2015/05/29 06:32:48, HariS wrote:
> Please review the changes done.

This is cleanup issue, Small change, Please review.

[Marijn Kruisselbrink, 2015-06-02 16:27:02]

On 2015/06/02 at 09:26:36, hari.singh1 wrote:
> On 2015/05/29 06:32:48, HariS wrote:
> > Please review the changes done.
> 
> This is cleanup issue, Small change, Please review.

sorry for the delay, lgtm although I'm not sure how you picked reviewers. I'm
not an owner of this file (looks like you'll need somebody from
src/chrome/OWNERS for that)

[HariS, 2015-06-03 05:40:18]

hari.singh1@samsung.com changed reviewers:
+ thakis@chromium.org
- mek@chromium.org, miket@chromium.org

[HariS, 2015-06-03 05:43:50]

On 2015/06/02 16:27:02, Marijn Kruisselbrink wrote:
> On 2015/06/02 at 09:26:36, hari.singh1 wrote:
> > On 2015/05/29 06:32:48, HariS wrote:
> > > Please review the changes done.
> > 
> > This is cleanup issue, Small change, Please review.
> 
> sorry for the delay, lgtm although I'm not sure how you picked reviewers. I'm
> not an owner of this file (looks like you'll need somebody from
> src/chrome/OWNERS for that)


Thank you Mr Marijn Kruisselbrink.

Changed the reviewer to thakis@chromium.org.

Hello Mr Nico ,

Please provide your approval so I can go ahead and land this patch.

[Nico, 2015-06-04 22:30:53]

code looks fine, but please fix your cl description (it has typos, it has lines
longer than 80 chars, etc.
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html is a good
summary of how commit messages should look – you don't need to stay below 50
chars for the first line, but you should stay below 80)

[HariS, 2015-06-05 03:33:48]

On 2015/06/04 22:30:53, Nico wrote:
> code looks fine, but please fix your cl description (it has typos, it has
lines
> longer than 80 chars, etc.
> http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html is a good
> summary of how commit messages should look – you don't need to stay below 50
> chars for the first line, but you should stay below 80)

Hello Mr Nico,


Updated the cl comments as per the guidelines suggested.
Please provide lgtm so I can go ahead and land the patch. 

Thanks

[Nico, 2015-06-05 19:39:17]

On 2015/06/05 03:33:48, HariS wrote:
> On 2015/06/04 22:30:53, Nico wrote:
> > code looks fine, but please fix your cl description (it has typos, it has
> lines
> > longer than 80 chars, etc.
> > http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html is a
good
> > summary of how commit messages should look – you don't need to stay below 50
> > chars for the first line, but you should stay below 80)
> 
> Hello Mr Nico,
> 
> 
> Updated the cl comments as per the guidelines suggested.

The guidelines I linked to say to have a blank line between the first line and
the rest. Either make the description shorter or do one line summary then blank
line then more text describing details (see the page I linked to)

Maybe

  Use push_back(ptr.Pass()) instead of push_back(ptr.release())

  This converts all files in chrome/browser/renderer_host

  BUG=457697

or something like that. (Since it's only one file, maybe you could convert more
than just that dir?)

[HariS, 2015-06-08 05:16:02]

On 2015/06/05 19:39:17, Nico wrote:
> On 2015/06/05 03:33:48, HariS wrote:
> > On 2015/06/04 22:30:53, Nico wrote:
> > > code looks fine, but please fix your cl description (it has typos, it has
> > lines
> > > longer than 80 chars, etc.
> > > http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html is a
> good
> > > summary of how commit messages should look – you don't need to stay below
50
> > > chars for the first line, but you should stay below 80)
> > 
> > Hello Mr Nico,
> > 
> > 
> > Updated the cl comments as per the guidelines suggested.
> 
> The guidelines I linked to say to have a blank line between the first line and
> the rest. Either make the description shorter or do one line summary then
blank
> line then more text describing details (see the page I linked to)
> 
> Maybe
> 
>   Use push_back(ptr.Pass()) instead of push_back(ptr.release())
> 
>   This converts all files in chrome/browser/renderer_host
> 
>   BUG=457697
> 
> or something like that. (Since it's only one file, maybe you could convert
more
> than just that dir?)

Hello Mr Nico,

Updated the cl description.
Looking in other files, Will upload separate Patch covering as many as possible
files I could find.
Please approve this so this can be landed.

[Nico, 2015-06-08 17:03:43]

lgtm

[HariS, 2015-06-09 03:46:17]

The CQ bit was checked by hari.singh1@samsung.com

[commit-bot: I haz the power, 2015-06-09 03:46:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1156373011/1

[commit-bot: I haz the power, 2015-06-09 04:36:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-09 04:37:50]

Patchset 1 (id:??) landed as
https://crrev.com/af730bf4ae6622680c6955b9d17084e4f4a29380
Cr-Commit-Position: refs/heads/master@{#333444}