Index: src/mips/full-codegen-mips.cc |
diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc |
index 1f12011803d2d7225f719165b61584b4b83b5176..ee8475a9eb73329ab8d732a1935b965317f0ea3b 100644 |
--- a/src/mips/full-codegen-mips.cc |
+++ b/src/mips/full-codegen-mips.cc |
@@ -1677,21 +1677,12 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) { |
__ lw(a3, FieldMemOperand(a3, JSFunction::kLiteralsOffset)); |
__ li(a2, Operand(Smi::FromInt(expr->literal_index()))); |
__ li(a1, Operand(constant_properties)); |
- int flags = expr->fast_elements() |
- ? ObjectLiteral::kFastElements |
- : ObjectLiteral::kNoFlags; |
- flags |= expr->has_function() |
- ? ObjectLiteral::kHasFunction |
- : ObjectLiteral::kNoFlags; |
- __ li(a0, Operand(Smi::FromInt(flags))); |
- int properties_count = constant_properties->length() / 2; |
- if (expr->may_store_doubles() || expr->depth() > 1 || |
- masm()->serializer_enabled() || flags != ObjectLiteral::kFastElements || |
- properties_count > FastCloneShallowObjectStub::kMaximumClonedProperties) { |
+ __ li(a0, Operand(Smi::FromInt(expr->ComputeFlags()))); |
+ if (MustCreateObjectLiteralWithRuntime(expr)) { |
__ Push(a3, a2, a1, a0); |
__ CallRuntime(Runtime::kCreateObjectLiteral, 4); |
} else { |
- FastCloneShallowObjectStub stub(isolate(), properties_count); |
+ FastCloneShallowObjectStub stub(isolate(), expr->properties_count()); |
__ CallStub(&stub); |
} |
PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG); |
@@ -1883,21 +1874,10 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
Comment cmnt(masm_, "[ ArrayLiteral"); |
expr->BuildConstantElements(isolate()); |
- int flags = expr->depth() == 1 |
- ? ArrayLiteral::kShallowElements |
- : ArrayLiteral::kNoFlags; |
- |
- ZoneList<Expression*>* subexprs = expr->values(); |
- int length = subexprs->length(); |
Handle<FixedArray> constant_elements = expr->constant_elements(); |
- DCHECK_EQ(2, constant_elements->length()); |
- ElementsKind constant_elements_kind = |
- static_cast<ElementsKind>(Smi::cast(constant_elements->get(0))->value()); |
bool has_fast_elements = |
- IsFastObjectElementsKind(constant_elements_kind); |
- Handle<FixedArrayBase> constant_elements_values( |
- FixedArrayBase::cast(constant_elements->get(1))); |
+ IsFastObjectElementsKind(expr->constant_elements_kind()); |
AllocationSiteMode allocation_site_mode = TRACK_ALLOCATION_SITE; |
if (has_fast_elements && !FLAG_allocation_site_pretenuring) { |
@@ -1911,8 +1891,8 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
__ lw(a3, FieldMemOperand(a3, JSFunction::kLiteralsOffset)); |
__ li(a2, Operand(Smi::FromInt(expr->literal_index()))); |
__ li(a1, Operand(constant_elements)); |
- if (expr->depth() > 1 || length > JSObject::kInitialMaxFastElementArray) { |
- __ li(a0, Operand(Smi::FromInt(flags))); |
+ if (MustCreateArrayLiteralWithRuntime(expr)) { |
+ __ li(a0, Operand(Smi::FromInt(expr->ComputeFlags()))); |
__ Push(a3, a2, a1, a0); |
__ CallRuntime(Runtime::kCreateArrayLiteral, 4); |
} else { |
@@ -1922,6 +1902,8 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG); |
bool result_saved = false; // Is the result saved to the stack? |
+ ZoneList<Expression*>* subexprs = expr->values(); |
+ int length = subexprs->length(); |
// Emit code to evaluate all the non-constant subexpressions and to store |
// them into the newly cloned array. |
@@ -1939,7 +1921,7 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
VisitForAccumulatorValue(subexpr); |
- if (IsFastObjectElementsKind(constant_elements_kind)) { |
+ if (has_fast_elements) { |
int offset = FixedArray::kHeaderSize + (i * kPointerSize); |
__ lw(t2, MemOperand(sp, kPointerSize)); // Copy of array literal. |
__ lw(a1, FieldMemOperand(t2, JSObject::kElementsOffset)); |