Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1156303013: Don't make unnecessary copy of ChildToParentMap (Closed)

Created:
5 years, 6 months ago by jbauman
Modified:
5 years, 6 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't make unnecessary copy of ChildToParentMap The right branch of the ternary was an rvalue, so the entire ternary operator made a copy of the child to parent map. This is expensive and is unnecessary. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/84b141c3e588831b4d7436fc67068ec121372b04 Cr-Commit-Position: refs/heads/master@{#333102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M cc/surfaces/surface_aggregator.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbauman
5 years, 6 months ago (2015-06-05 13:18:48 UTC) #2
enne (OOO)
lgtm
5 years, 6 months ago (2015-06-05 17:51:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156303013/1
5 years, 6 months ago (2015-06-05 17:51:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 18:54:08 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 19:06:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84b141c3e588831b4d7436fc67068ec121372b04
Cr-Commit-Position: refs/heads/master@{#333102}

Powered by Google App Engine
This is Rietveld 408576698