Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1156303011: Fix Color Enhancer global scopes. (Closed)

Created:
5 years, 6 months ago by Peter Wen
Modified:
5 years, 6 months ago
Reviewers:
mustaq, kevers
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Color Enhancer global scopes. BUG=465457 Committed: https://crrev.com/661d21eb397626328cafa5b126c47d4b657f7658 Cr-Commit-Position: refs/heads/master@{#333283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+750 lines, -733 lines) Patch
M ui/accessibility/extensions/colorenhancer/src/cvd.js View 2 chunks +370 lines, -370 lines 0 comments Download
M ui/accessibility/extensions/colorenhancer/src/popup.js View 1 chunk +380 lines, -363 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Wen
Hi Kevin and Mustaq, Likely the last CL I contribute to Color Enhancer. This isolates ...
5 years, 6 months ago (2015-06-04 15:36:00 UTC) #2
kevers
lgtm
5 years, 6 months ago (2015-06-04 16:21:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156303011/1
5 years, 6 months ago (2015-06-08 17:11:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 17:22:56 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 17:23:41 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/661d21eb397626328cafa5b126c47d4b657f7658
Cr-Commit-Position: refs/heads/master@{#333283}

Powered by Google App Engine
This is Rietveld 408576698