Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1156303010: Oilpan: provide eager 'operator new' overload for ServiceWorker. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: provide eager 'operator new' overload for ServiceWorker. ServiceWorker needs to overload 'operator new' in order to have its instances be allocated on the eagerly swept heap. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/modules/serviceworkers/ServiceWorker.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
please take a look.
5 years, 6 months ago (2015-06-04 11:27:39 UTC) #2
haraken
LGTM Just to confirm: Without having the OPERATOR_NEW, we'll hit the isEagerHeapIndex assert (and thus ...
5 years, 6 months ago (2015-06-04 12:45:39 UTC) #3
sof
On 2015/06/04 12:45:39, haraken wrote: > LGTM > > Just to confirm: Without having the ...
5 years, 6 months ago (2015-06-04 12:49:59 UTC) #4
haraken
On 2015/06/04 12:49:59, sof wrote: > On 2015/06/04 12:45:39, haraken wrote: > > LGTM > ...
5 years, 6 months ago (2015-06-04 12:51:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156303010/1
5 years, 6 months ago (2015-06-04 12:53:32 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 12:58:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196496

Powered by Google App Engine
This is Rietveld 408576698