Use Point, Size, and Rect in layout2.dart

sky/sdk/lib/framework/fn2.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 library fn;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:mirrors';
 import 'dart:sky' as sky;
@@ skipping 925 matching lines @@
   Text(this.data) : super(key: '*text*');
   final String data;
   bool get interchangeable => true;
   UINode build() => new Paragraph(children: [new TextFragment(data)]);
 }
 
 
 // for now, but only for now:
 
 class RenderSolidColor extends RenderDecoratedBox {
-  final double desiredHeight;
-  final double desiredWidth;
+  final sky.Size desiredSize;
   final int backgroundColor;
 
-  RenderSolidColor(int backgroundColor, { this.desiredHeight: double.INFINITY,
-                                          this.desiredWidth: double.INFINITY })
+  RenderSolidColor(int backgroundColor, { this.desiredSize })

[Hixie, 2015/05/28 18:45:22]

If it's a required argument (which it appears it now is), we shouldn't have it
be optional.

But I'd rather we made Size constant and had it be optional, defaulting to
infinity.

       : backgroundColor = backgroundColor,
         super(new BoxDecoration(backgroundColor: backgroundColor));
 
   BoxDimensions getIntrinsicDimensions(BoxConstraints constraints) {
     return new BoxDimensions.withConstraints(constraints,

[Hixie, 2015/05/28 18:45:22]

What if desiredSize is null?

-                                             height: desiredHeight,
-                                             width: desiredWidth);
+                                             width: desiredSize.width,
+                                             height: desiredSize.height);
   }
 
   void layout(BoxConstraints constraints, { RenderNode relayoutSubtreeRoot }) {
-    width = constraints.constrainWidth(desiredWidth);
-    height = constraints.constrainHeight(desiredHeight);
+    size = constraints.constrain(desiredSize);
     layoutDone();
   }
 
   void handlePointer(sky.PointerEvent event) {
     if (event.type == 'pointerdown')
       decoration = new BoxDecoration(backgroundColor: 0xFFFF0000);
     else if (event.type == 'pointerup')
       decoration = new BoxDecoration(backgroundColor: backgroundColor);
   }
 }
 
 class Rectangle extends RenderNodeWrapper {
 
   Rectangle(this.color, {
     Object key
   }) : super(
     key: key
   );
 
   final int color;
 
   RenderSolidColor root;
-  RenderSolidColor createNode() => new RenderSolidColor(color, desiredWidth: 40.0, desiredHeight: 130.0);
+  RenderSolidColor createNode() => new RenderSolidColor(color, desiredSize: new sky.Size(40.0, 130.0));
 
   static final Rectangle _emptyRectangle = new Rectangle(0);
   RenderNodeWrapper get emptyNode => _emptyRectangle;
 
 }